Skip to content

fix(plugin-export): restore plugin mode and update JSON export schema#481

Merged
SnaveSutit merged 2 commits into
Animated-Java:v1.9.0from
Meekiavelique:main
Mar 27, 2026
Merged

fix(plugin-export): restore plugin mode and update JSON export schema#481
SnaveSutit merged 2 commits into
Animated-Java:v1.9.0from
Meekiavelique:main

Conversation

@Meekiavelique
Copy link
Copy Markdown
Contributor

Skiping datapack compilation when plugin mode is enabled, include some more settings in the json export and fixed serialization issues for text displays.

@SnaveSutit
Copy link
Copy Markdown
Contributor

There is a new plugin json schema that has been planned for the next release.

https://gist.github.com/SnaveSutit/5452228de4af4b2f42e9481264c2df0c

I realize this isn't super publicly known, but it has been discussed in the plugin discussion thread in the #chat channel on our discord.

Unfortunately I won't be able to merge this PR, as it will cause a bunch of merge conflicts with the rewrite branch that I'd rather avoid.

Please follow the steps in CONTRIBUTING.md in the future. I don't want you spending your time implementing stuff that I won't be able to merge. 😢

Thank you for understanding!

@Meekiavelique
Copy link
Copy Markdown
Contributor Author

I updated the json schema
And what do you mean by conflicts with the rewrite branch

@SnaveSutit
Copy link
Copy Markdown
Contributor

SnaveSutit commented Mar 17, 2026

The entire plugin is being rewritten from almost scratch again for Blockbench v5.0 due to major plugin API changes.

Changing / adding to the history of main will cause merge conflicts with the massively different rewrite branch

@SnaveSutit
Copy link
Copy Markdown
Contributor

On top of this, it is not possible to export texture_pallets correctly, as they function differently from how Variants function currently

@boxic
Copy link
Copy Markdown

boxic commented Mar 19, 2026

The entire plugin is being rewritten from almost scratch again for Blockbench v5.0 due to major plugin API changes.

Changing / adding to the history of main will cause merge conflicts with the massively different rewrite branch

What would you suggest as the best route we take for getting plugin export back into the feature list? I've brought Meek onto the SLAM! project with a secondary goal of updating this feature for AJ, to continue supporting it as a part of our development pipeline. So if there's anything that he could do to help this along, feel free to point him in a direction!

@SnaveSutit
Copy link
Copy Markdown
Contributor

Wait until 2.0.0 for v5.0 releases. I plan on including the fully finished plugin exporter for this version.

@boxic
Copy link
Copy Markdown

boxic commented Mar 20, 2026

Wait until 2.0.0 for v5.0 releases. I plan on including the fully finished plugin exporter for this version.

Is there any way Meek could help you guys reach that release sooner? iirc it's been in the works for some time now.

@SnaveSutit
Copy link
Copy Markdown
Contributor

SnaveSutit commented Mar 21, 2026

It's only me working on AJ, and I don't have the time to manage people and make sure everyone aligns with my vision right now unfortunately.

The plugin export is a very small part of Animated Java, so just doing that wouldn't greatly impact the dev time 2.0 requires.

@boxic
Copy link
Copy Markdown

boxic commented Mar 21, 2026

It's only me working on AJ, and I don't have the time to manage people and make sure everyone aligns with my vision right now unfortunately.

The plugin export is a very small part of Animated Java, so just doing that wouldn't greatly impact the dev time 2.0 requires.

Assuming the plugin export meets the requirements/standard for the current latest release, would it be able to be merged so it's an option for those who are waiting?

@SnaveSutit
Copy link
Copy Markdown
Contributor

I will try to merge it into 1.9.0. You can help test the ko-fi beta since you're in that channel on Discord.

@SnaveSutit
Copy link
Copy Markdown
Contributor

Please update this PR to target the v1.9.0 branch

@SnaveSutit SnaveSutit added the ✨ Enhancement New feature or request label Mar 25, 2026
@Meekiavelique Meekiavelique changed the base branch from main to v1.9.0 March 27, 2026 07:43
@Meekiavelique
Copy link
Copy Markdown
Contributor Author

Done

@SnaveSutit SnaveSutit merged commit d0433f3 into Animated-Java:v1.9.0 Mar 27, 2026
SnaveSutit added a commit that referenced this pull request Mar 27, 2026
Skiping datapack compilation when plugin mode is enabled, include some
more settings in the json export and fixed serialization issues for text
displays.
SnaveSutit added a commit that referenced this pull request Mar 27, 2026
Skiping datapack compilation when plugin mode is enabled, include some
more settings in the json export and fixed serialization issues for text
displays.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants