Skip to content

Refactor CSS to enforce strict separation, specificity, and color variables#382

Open
Animation-EdNum wants to merge 1 commit intomainfrom
refactor/css-best-practices-187962680270049942
Open

Refactor CSS to enforce strict separation, specificity, and color variables#382
Animation-EdNum wants to merge 1 commit intomainfrom
refactor/css-best-practices-187962680270049942

Conversation

@Animation-EdNum
Copy link
Copy Markdown
Owner

Refactored assets/css/shared.css, index.html, webapps/simulateur_bluebot.html, and alpha/webapps/jeu_de_la_grue.html to strictly adhere to project CSS standards. This involved removing inline styles, removing !important declarations by increasing specificity, and replacing hardcoded colors with a unified system of CSS variables.


PR created automatically by Jules for task 187962680270049942 started by @Animation-EdNum

…d colors

- Extracted standard and recurring hex/rgba colors into semantic Tailwind-style CSS variables within `:root` of `shared.css`.
- Replaced over 100 hardcoded color values across `shared.css`, `simulateur_bluebot.html`, and `jeu_de_la_grue.html` with these new variables.
- Eliminated 67 `!important` declarations across `shared.css` and `simulateur_bluebot.html` by properly structuring CSS selectors to use higher specificity (e.g., adding `html body`).
- Replaced 135 inline `style="..."` attributes with utility CSS classes, merging existing classes correctly to avoid HTML validation issues with duplicate `class` attributes.
- Ensured no regression on the E2E test suite (50 tests passed).

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant