Changes to menu and san() function#9
Merged
Anish-M-code merged 2 commits intoAnish-M-code:masterfrom Oct 29, 2022
Merged
Conversation
Owner
|
@rohithpeddi7 please remove .pyc files and _ _ pycache _ _ folder , rest of code looks fine to me. |
Contributor
Author
|
@Anish-M-code Yeah sorry! Now I got rid of them. |
Owner
|
Thanks for contributing @rohithpeddi7 👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @Anish-M-code , I have made changes to san() function which previously called itself. This method wasn't good because function call upon function call were being added to stack and there was chance of stack overflow. So I instead changed the function not to call itself, and added while(True): san(). This approach is better because the auxiliary space is O(1). I have also added option to menu to specify that with input as 'c', the program ends. Please let me know if there are any issues. Thanks!