-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
According to our last peer-to-peer meeting, I'll share some findings that could implement in your code:
- Good job with the implemented validation of the form, as you noticed it's better to implement the client-side validations to avoid mistakes with the HTML-validations form.
- You would try to implement additional aids for accessibility as bordered inputs or icons where the user gets an error, however, you did it great setting the error message near the input.
- We found an error when you select the
.buttonsto implement the event listener due to that select all the buttons instead of the project buttons. - For the variable and functions according to the recommended practices it's required to use camelCase.
- To avoid complications with text concatenation using
'text' + variableyou could try usingtext ${variable}.
Thank you very much!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels