Skip to content

fix: Save channel_name to localStorage from URL parameters #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnnaCodit merged 1 commit into from
Mar 17, 2026
Merged

fix: Save channel_name to localStorage from URL parameters #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion js/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ function loadSettings() {
}
}

const storedChannel = urlParams.get('channel_name') || localStorage.getItem('channel_name');
const urlChannel = urlParams.get('channel_name');
if (urlChannel) {
localStorage.setItem('channel_name', urlChannel);
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Sanitize URL channel before persisting

Persisting channel_name directly from query params stores malformed values (for example %20foo or trailing spaces) into localStorage, and loadSettings() then treats that value as ready on future visits, which can repeatedly initialize chat with an invalid channel even when the bad URL is no longer present. This regression is introduced by the new persistence path; unlike the manual save flow, this branch does not trim/normalize before saving.

Useful? React with 👍 / 👎.

}
const storedChannel = urlChannel || localStorage.getItem('channel_name');
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the logic is correct, this line is a bit redundant. Since you've just updated localStorage with urlChannel if it exists, you can simplify this by always reading from localStorage. This makes the logic clearer: first update localStorage from the URL if available, then read from localStorage as the single source of truth for the session's setting.

Suggested change
const storedChannel = urlChannel || localStorage.getItem('channel_name');
const storedChannel = localStorage.getItem('channel_name');

const storedRestartTime = urlParams.get('restart_time') || localStorage.getItem('restart_time');
const storedAvatarInput = urlParams.get('win_avatar_enable') || localStorage.getItem('win_avatar_enable');
const storedSoundInput = urlParams.get('sound_enable') || localStorage.getItem('sound_enable');
Expand Down