Bugfix/list all books#5
Open
Annie-dev01 wants to merge 3 commits into
Open
Conversation
jsamchineme
reviewed
Oct 15, 2022
| let books = [] | ||
| import fs from 'fs'; | ||
|
|
||
| export const getBooks = (req, res) => { |
Collaborator
There was a problem hiding this comment.
your tabs are still not 4 spaces
|
|
||
| export const getBooks = (req, res) => { | ||
| res.send(books); | ||
| const books = JSON.parse(fs.readFileSync('./data/books.json')); |
Collaborator
There was a problem hiding this comment.
use module imports to pull in the json.
import books from './data/books.json
| books.push({ ...book, id: uuidv4()}); | ||
| res.send(`Book with the name ${book.bookTitle} added to the database!`); | ||
| } | ||
| let books = [...JSON.parse(fs.readFileSync('./data/books.json'))] |
Collaborator
There was a problem hiding this comment.
I see that this JSON.parse(fs.readFileSync('./data/books.json')) is being used many places. You will probably not need this after implementing the module import suggestion. However, such reused code pieces can be declared at the top of the file and used in all the functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.