Restored missing SensorInfo parameters, fixed mqtt global variable shadowing and some linting#64
Merged
AnotherDaniel merged 1 commit intoAnotherDaniel:mainfrom Oct 29, 2025
Merged
Conversation
…adowing, fixed some linting errors
|
Seems this PR is also fixing #65 |
Contributor
Author
|
@AnotherDaniel ping in case you did not get the notification about the PR. The master branch is currently broken. |
AnotherDaniel
approved these changes
Oct 29, 2025
Owner
AnotherDaniel
left a comment
AnotherDaniel
left a comment
There was a problem hiding this comment.
Looks good - thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the integration was not updating any values my HA anymore. luckily claude was able to spot the problem pretty quickly.
Also my local linter suggested that pubunits is unused in mqtt, because removing the global definition would create a local variable shadowing issue, making pubunits always false. Its now replaced by a closure pattern. But i have not tested it, as i use the ha version.
i also bumped the version to 1.7.1 in the code.
I also want to thank you for creating the integration in the first place and still maintaining it. Im glad i can help.