fix(updates): scan all filesystem stacks for image updates#514
Merged
Conversation
ImageUpdateService previously discovered stacks by iterating Docker containers, which meant stacks without containers (e.g. after docker compose down) were silently excluded from update checks. Switch to a hybrid discovery approach: enumerate stacks from the filesystem via FileSystemService.getStacks(), parse compose files for image refs with .env variable resolution, then augment with container-based image discovery for running stacks. Also cleans up stale stack_update_status entries when stacks are deleted or no longer exist on disk, and replaces the plain update-available tooltip with an animated cursor follow pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageUpdateService.checkNode()discovered stacks by iterating Docker containers, meaning stacks without containers (e.g. afterdocker compose down) were silently excluded from update checks.envvariable resolution, then augments with container-based image discovery for running stacksstack_update_statusentries are now cleaned up when stacks are deleted and pruned during scans for stacks no longer on disktitle="Update available"tooltip on the sidebar update dot with the animated cursor-follow patternTest plan
/simplify(3 parallel agents)arr-net(no containers) was missing from image-update statuscomposestale entry exists in update status but not on filesystem (stale cleanup addresses this)/api/image-updatesresponse