Let run_python to use user globals, not .core globals to access tools and variables.#122
Merged
Let run_python to use user globals, not .core globals to access tools and variables.#122
run_python to use user globals, not .core globals to access tools and variables.#122Conversation
… and variables.
The dialoghelper.core globals() have limited nubmer of tools (smaller than what `__llmtools__` define)
Tools like rg, sed, bash were not avaliable, same for user defined tools.
We change globals() to result of _find_frame_dict('__msg_id') (mechanism as inspecttools use).
Contributor
|
Great idea - thanks! :) |
jph00
changed the title
run_python to use user globals, not .core globals to access tools and variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dialoghelper.core globals() have limited nubmer of tools (smaller than what
__llmtools__define)Tools like rg, sed, bash were not avaliable, same for user defined tools.
We change globals() to result of _find_frame_dict('__msg_id') (mechanism as inspecttools use).