Fix html2ft edge cases, group custom attrs, add tests

[callmephilip]

---

name: Pull Request
about: Propose changes to the codebase
title: '[PR] '
labels: ''
assignees: ''

---

Related Issue

Current issues with html2f implementation

<div x-transition:enter.scale.80 x-transition:leave.scale.90>hello</div> incorrectly converts to Div('hello', **{'x-transition:enter.scale.80':''}, **{'x-transition:leave.scale.90':''})

<div id="1">hello</div> incorrectly converts to Div('hello', id='1') with attrs1st=True

(Not a bug but inconvenience):

Div('Hello 👋', x_show='open', **{'x-transition:enter':'transition duration-300'}, **{'x-transition:enter-start':'opacity-0 scale-90'}) <- custom attributes spread around multiple dictionaries as opposed to being grouped into 1 dictionary, e.g.

Div('Hello 👋', x_show='open', **{'x-transition:enter':'transition duration-300', 'x-transition:enter-start':'opacity-0 scale-90'})

Proposed Changes
This PR addresses the issues mentioned above ⬆️ and adds tests for htm2ft function

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

• Bug fix (non-breaking change which fixes an issue)

[gitnotebooks]

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/581

[jph00]

Thanks @callmephilip ! Can you please run nbdev_export to fix CI?

[callmephilip]

Thanks @callmephilip ! Can you please run nbdev_export to fix CI?

I tried the following multiple times:

nbdev_export && nbdev_clean && nbdev_trust

Still no luck. It seems like something has happened to _modidx

[jph00]

Try updating to the latest nbdev maybe?

…

Message ID: ***@***.***>

[callmephilip]

nuked project directory and did a fresh checkout. looks good now

[jph00]

Many thanks :)