Conversation
9 tasks
jph00
reviewed
Apr 27, 2026
| # %% ../nbs/api/00_core.ipynb #26b147ba | ||
| @patch | ||
| def _endp(self:FastHTML, f, body_wrap, before=None): | ||
| def _endp(self:FastHTML, f, body_wrap, before:Optional[Callable|tuple]=None): |
Contributor
There was a problem hiding this comment.
I'm not a big fan of adding this complex typing tbh - not sure it's much of a win in dynamic environments, and adds clutter that (for me at least) makes it harder to see what's happening.
jph00
reviewed
Apr 27, 2026
| # %% ../nbs/api/00_core.ipynb #f5cb2c2b | ||
| @patch | ||
| def route(self:FastHTML, path:str=None, methods=None, name=None, include_in_schema=True, body_wrap=None, host=None, before=None): | ||
| def route(self:FastHTML, path:str=None, methods=None, name=None, include_in_schema=True, body_wrap=None, host=None, before:Optional[Callable|tuple]=None): |
Contributor
There was a problem hiding this comment.
...Ugh and it ends up cluttering every function it's threaded thru! :O
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allow multiple before functions in a route so you can do things like
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply:Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.