fix(core): rename parameter f to _f in _handle to prevent keyword argument collisions#894
Open
Hasnaathussain wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When route handlers accept an argument named
f(representing a file, form, or general parameter), invoking the handler via FastHTML's_handlefunction raisesTypeError: _handle() got multiple values for argument 'f'.This is because the first positional argument of
_handleis namedf, which collides with the keyword argument unpacked from the request payload.This PR renames the parameter in
_handlefromfto_f(both in the source notebooknbs/api/00_core.ipynband the exportedfasthtml/core.py) to prevent keyword collisions.I've also added a regression test demonstrating route registration and invocation with parameter
fworking seamlessly.Closes #834