Fix: Add missing verbose argument to vprint in ColBERTModel#63
Merged
bclavie merged 1 commit intoApr 1, 2025
Merged
Conversation
chaosisnotrandomitisrhythmic
referenced
this pull request
Mar 24, 2025
Collaborator
|
Thank you so much! My bad for the oversight :( releasing as |
bclavie
approved these changes
Apr 1, 2025
seanmacavaney
pushed a commit
to seanmacavaney/rerankers
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The
vprintcall inColBERTModel.__init__was missing its requiredverboseargument, which causes a TypeError. The function requires two arguments:Reproduction
The error can be reproduced with this simple code:
Breaking change
Looks like the bug was introduced in Commit 20be7bb
Changes
verboseparameter to thevprintcall inColBERTModel.__init__verbosea required parameter inColBERTModel.__init__to ensure proper initializationTesting
The fix ensures that logging behavior works as expected when initializing ColBERTModel instances. The model should now correctly respect the verbose level setting.
cc @ @bclavie thanks a lot for all the great work 🙌