Fixes #46#45
Conversation
|
I don't quite follow this PR, sorry! It seems that |
|
|
There's something I still don't understand so pulling this back to draft for now ... |
|
This PR started out to allow date-type parameters in tool functions. But I learned that the pre-existing support for Path-type parameters was incomplete:
So now, this PR simply fixes the situation for Path types. I will wait to submit a separate PR for dates until Paths are merged and working correctly. |
|
Ok, git PRs and nbdev both new to me so apologies for the scattered commits, but I think we're now good to go. |
|
Thanks! |
|
Sorry I actually reverted it, since on reflection fixing this properly required a bit more machinery, and a proper e2e test. |
datetime.date arguments can't be inferred by inspection so must be handled as custom types.