fix: remove stale type key from union schemas#80
Merged
jph00 merged 2 commits intoAnswerDotAI:mainfrom Mar 12, 2026
Merged
Conversation
Author
Collaborator
|
Thanks @thechandru for the revised PR. It looks like you accidentally deleted all the outputs. Can you put them back? Try to keep your diff nice and clean! :D |
Author
|
@jph00 - I am not entirely sure how I managed to do that. I did a run-all and then did a commit from solveit and that seems to have restored outputs. Not sure if I got it back to a sane diff for review. Happy to RTFM - not sure where to look :-) |
Collaborator
|
Very good! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When using union types with parameterized containers (e.g.
list[str] | None), the generated JSON schema includes a conflictingtype: objectkey alongsideanyOf, causing LLMs to return stringified arrays instead of proper JSON arrays.Reproduction:
Fix: In
_process_property, pop thetypekey whenanyOfis present. Per JSON Schema spec, keywords at the same level are ANDed — sotype: objectalongsideanyOfcreates a contradictory schema.After fix:
{'description': '', 'default': None, 'anyOf': [{'type': 'array', 'items': {'type': 'string'}}, {'type': 'null'}]}Verified: Tested end-to-end with Lisette — Claude now returns proper JSON arrays instead of stringified arrays. All nbdev-test tests pass.