Conversation
The only place ranges are allowed is now in time sum, not any more in the too large time shift operator. For now we remove the possibility to have multiple explicit indices in a sum, it's not actually used. Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Only printing remains to update Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
tbittar
reviewed
Sep 11, 2024
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class TimeExpansion: |
Collaborator
There was a problem hiding this comment.
Resolution rather than Expansion not to mix with Xpansion ?
Member
Author
There was a problem hiding this comment.
Since those objects are temporary (should be removed soon), I propose to leave it this way here.
However the word is used also in the PR about "operators expansion", we can think of another name there (although I find it quite appropriate !).
tbittar
approved these changes
Sep 11, 2024
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First work towards simplification:
(quite different because it changes the time granularity)
Allows to clarify concepts and code a bit.