contrib: Add renewable conversion to yaml components#59
Merged
Conversation
killian-scalian
changed the title
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
requested changes
Jan 8, 2025
Collaborator
tbittar
left a comment
tbittar
left a comment
There was a problem hiding this comment.
Requested changes in the comments
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
reviewed
Jan 8, 2025
tbittar
requested changes
Jan 8, 2025
Collaborator
tbittar
left a comment
tbittar
left a comment
There was a problem hiding this comment.
Encore quelques petites commantaires ;)
tbittar
requested changes
Jan 9, 2025
Collaborator
tbittar
left a comment
tbittar
left a comment
There was a problem hiding this comment.
Plus que 2 micro remarques
| self.study_path = study_input.service.config.study_path # type: ignore | ||
| else: | ||
| self.study = read_study_local(self.study_path) | ||
| self.study_path = resolve_path(study_input) |
Collaborator
There was a problem hiding this comment.
Tu dois inverser les 2 lignes sinon self.study_path n'est pas défini L31
Collaborator
Author
There was a problem hiding this comment.
Effectiveent
| else: | ||
| self.study = read_study_local(self.study_path) | ||
| self.study_path = resolve_path(study_input) | ||
|
|
Collaborator
There was a problem hiding this comment.
Et pour mieux tracer les éventuelles erreurs peut-être mettre plutôt elif isinstance(..., Path): .... else: raise TypeError(....)
tbittar
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.