Skip to content

Update artifact v4 #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JasonMarechal25 merged 6 commits into from
May 21, 2024
Merged

Update artifact v4 #805

JasonMarechal25 merged 6 commits into from
May 21, 2024

Conversation

@JasonMarechal25
Copy link
Contributor

@JasonMarechal25 JasonMarechal25 commented May 15, 2024

No description provided.

dependabot bot added 2 commits May 15, 2024 14:56
@dependabot @JasonMarechal25
Bump actions/download-artifact from 3 to 4
c55b840 
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @JasonMarechal25
Bump actions/upload-artifact from 3 to 4
ab6329c 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@JasonMarechal25 JasonMarechal25 changed the title Ci/artifactv4 Update artifact v4 May 15, 2024
@JasonMarechal25 JasonMarechal25 marked this pull request as ready for review May 15, 2024 14:09
@JasonMarechal25 JasonMarechal25 requested a review from a team May 15, 2024 14:09
flomnes
flomnes requested changes May 16, 2024
View reviewed changes
Copy link
Member

@flomnes flomnes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{download|upload}artifact@v4 is known to cause issues in CentOS7, see

On Antares_Simulator, it breaks on OL8 & CentOS7.

@JasonMarechal25
Copy link
Contributor Author

JasonMarechal25 commented May 21, 2024

{download|upload}artifact@v4 is known to cause issues in CentOS7, see

* [Composite Actions using Node 20 don't work with CentOS 7 actions/runner#2906](https://github.com/actions/runner/issues/2906)

* [node20 (and other version) binary used for running actions should be fully statically linked (including libc) actions/setup-node#922](https://github.com/actions/setup-node/issues/922)

On Antares_Simulator, it breaks on OL8 & CentOS7.

Yes. CentOS jobs are kept with v3. OL8 doesn't encounter any issue

@JasonMarechal25 JasonMarechal25 requested a review from flomnes May 21, 2024 07:59
@JasonMarechal25 JasonMarechal25 marked this pull request as draft May 21, 2024 07:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JasonMarechal25 JasonMarechal25 marked this pull request as ready for review May 21, 2024 13:40
@JasonMarechal25 JasonMarechal25 merged commit 9f2c7af into develop May 21, 2024
@JasonMarechal25 JasonMarechal25 deleted the ci/artifactv4 branch May 21, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flomnes flomnes flomnes approved these changes

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JasonMarechal25 @flomnes