Skip to content

Fix .NET SDK version pin and add CI workflow#2

Merged
AnthonyDegroote merged 1 commit into
mainfrom
copilot/analyse-repo
Mar 24, 2026
Merged

Fix .NET SDK version pin and add CI workflow#2
AnthonyDegroote merged 1 commit into
mainfrom
copilot/analyse-repo

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

global.json pinned SDK 10.0.201 which doesn't exist in the environment, making dotnet entirely non-functional. No CI pipeline existed to catch this or future regressions.

Changes

  • global.json — bump pinned version 10.0.20110.0.102 (latest available .NET 10 SDK); rollForward: latestFeature unchanged
  • .github/workflows/ci.yml — new GitHub Actions workflow: restore → build → test on every push/PR to main, scoped to contents: read

Co-authored-by: AnthonyDegroote <13833439+AnthonyDegroote@users.noreply.github.com>
Agent-Logs-Url: https://github.com/AnthonyDegroote/SoftwareCraftLab/sessions/5eaafa2b-527d-45fe-8210-b189cd5d9147
@AnthonyDegroote AnthonyDegroote marked this pull request as ready for review March 24, 2026 04:42
Copilot AI review requested due to automatic review settings March 24, 2026 04:42
@AnthonyDegroote AnthonyDegroote merged commit dc1c9d8 into main Mar 24, 2026
3 checks passed
@AnthonyDegroote AnthonyDegroote deleted the copilot/analyse-repo branch March 24, 2026 04:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a broken .NET SDK pin that prevented dotnet from working, and introduces a basic GitHub Actions CI pipeline to restore/build/test on pushes and PRs targeting main.

Changes:

  • Update global.json SDK version pin from 10.0.201 to 10.0.102.
  • Add a new GitHub Actions workflow to run dotnet restore, dotnet build, and dotnet test on ubuntu-latest.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
global.json Updates the pinned .NET SDK version to a working version.
.github/workflows/ci.yml Adds CI workflow to automatically restore/build/test on pushes/PRs to main.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: '10.0.x'
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI installs .NET using dotnet-version: '10.0.x', which can drift from the pinned global.json SDK (10.0.102). That reduces reproducibility and can mask SDK-specific regressions. Consider installing the exact SDK from global.json (e.g., global-json-file: global.json) or pinning dotnet-version to 10.0.102 so local and CI builds use the same toolchain.

Suggested change
dotnet-version: '10.0.x'
global-json-file: global.json

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants