This repository was archived by the owner on Jan 4, 2023. It is now read-only.
Merged
Conversation
This patch addresses a compilation problem where a
pointer is compared with greater than sign ?
clang doesn't like that and throws an error, while gcc
silently shallows this.
I figured this doesn't make any sense and that
perhaps you mean to check if the pointer is not `nullptr`?
```cpp
error: ordered comparison between pointer and zero ('QMap<SDL_JoystickID, InputDevice *> *'
(aka 'QMap<int, InputDevice *> *') and 'int')
if (joysticks > 0)
~~~~~~~~~ ^ ~
1 error generated.
```
After some testing I didn't noticed any changes in
the behavior of the application and it continues working
as before, just like when compiled with gcc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses a compilation problem where a
pointer is compared with greater than sign ?
clang doesn't like that and throws an error, while gcc
silently shallows this.
I figured this doesn't make any sense and that
perhaps you mean to check if the pointer is not
nullptr?After some testing I didn't noticed any changes in
the behavior of the application and it continues working
as before, just like when compiled with gcc.