bugfix: druntime may fail to determine the timing of ticks#3
Merged
AntonMeep merged 1 commit intoAntonMeep:masterfrom Jul 24, 2018
Merged
bugfix: druntime may fail to determine the timing of ticks#3AntonMeep merged 1 commit intoAntonMeep:masterfrom
AntonMeep merged 1 commit intoAntonMeep:masterfrom
Conversation
Owner
|
Looks like druntime fails to determine CPU frequency so it falls back to 1 megaticks/second. This means that profdump shouldn't show function times in seconds in such cases but rather show ticks. Thanks for the PR, I'll open an issue about that unknown frequency thing. |
Contributor
Author
|
thank you :) |
Owner
|
I also tagged a new release v0.4.3 with this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't explain why druntime fails but the second branch in the if-statement in druntime/src/rt/trace.d, (function trace_time line 306 in dmd-2.081.1) activated on my computer.
Besides this bug. Nice tool! It really helped me understand where my bottlenecks where.