Inverse Dynamics of Muscle Systems and other changes#43
Conversation
There was a problem hiding this comment.
Hello @JacobAdamsen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request focuses on updating the Inverse Dynamics of Muscle Systems tutorial, marking the 'The Mechanical Elements' tutorial as deleted, and renaming 'Making Things Move' to 'Motion Capture movement'. The tutorial updates include image replacements, text revisions, equation insertion method updates, and ensuring models run with reasonable results. A key change involves modifying the muscle model's constant strength in calibration.any.
Highlights
- Inverse Dynamics Tutorial Update: The 'Inverse Dynamics of Muscle Systems' tutorial has been updated with new images, revised text, and improved equation formatting. Models are now verified to run correctly.
- Tutorial Deletion: The tutorial 'The Mechanical Elements' has been marked as deleted.
- Tutorial Renaming: The tutorial 'Making Things Move' has been renamed to 'Motion Capture Movement'.
- Muscle Model Strength Modification: The
F0parameter in theAnyMuscleModelwithincalibration.anyhas been changed from 600 to 400.
Changelog
Click here to see the changelog
- MuscleRecruitment/Downloads/calibration.any
- Modified the
F0parameter (muscle strength) in theAnyMuscleModelfrom 600 to 400. This change affects the simple muscle model's constant strength.
- Modified the
- MuscleRecruitment/Inverse_dynamics.md
- Removed the
caution_old_tutorialcaution box. - Replaced the image insertion method from
to the sphinx{image} path/to/image :alt: alt text :align: center :width: 40%format for better control over image attributes. - Minor text changes for clarity and flow.
- Removed the
- MuscleRecruitment/lesson1.md
- Removed the
caution_old_tutorialcaution box. - Updated the equation formatting to use
equation*environments for better rendering. - Minor text changes for clarity and flow.
- Replaced the image insertion method from
to the sphinx{image} path/to/image :alt: alt text :align: center :width: 50%format for better control over image attributes. - Added the location of the muscle force in the Chart view as
Main.MyStudy.Output.Model.M1.Fm
- Removed the
- MuscleRecruitment/lesson2.md
- Removed the
caution_old_tutorialcaution box. - Updated the equation formatting to use
equation*environments for better rendering. - Minor text changes for clarity and flow.
- Replaced the image insertion method from
to the sphinx{image} path/to/image :alt: alt text :align: center :width: 80%format for better control over image attributes.
- Removed the
- MuscleRecruitment/lesson3.md
- Removed the
caution_old_tutorialcaution box. - Updated the image insertion method from
to the sphinx{image} path/to/image :alt: alt text :align: center :width: 90%format for better control over image attributes. - Added a note about expected Notices during model loading.
- Updated the location of the muscle activity in the Chart view as
Main.Bike2D.Study.Output.Model.Leg2D.Right.Mus - Minor text changes for clarity and flow.
- Removed the
- MuscleRecruitment/lesson4.md
- Removed the
caution_old_tutorialcaution box. - Updated the image insertion method from
to the sphinx{image} path/to/image :alt: alt text :align: center :width: 90%format for better control over image attributes. - Minor text changes for clarity and flow.
- Removed the
- MuscleRecruitment/lesson5.md
- Removed the
caution_old_tutorialcaution box. - Updated the image insertion method from
to the sphinx{image} path/to/image :alt: alt text :align: center :width: 90%format for better control over image attributes. - Updated the location of the max muscle activity in the Chart view as
Main.Bike2D.Study.Output.MaxMuscleActivity - Minor text changes for clarity and flow.
- Removed the
- MuscleRecruitment/lesson6.md
- Removed the
caution_old_tutorialcaution box. - Updated the equation formatting to use
equation*environments for better rendering. - Updated the image insertion method from
to the sphinx{image} path/to/image :alt: alt text :align: center :width: 90%format for better control over image attributes. - Added references to Praagman et al.
- Minor text changes for clarity and flow.
- Removed the
- MuscleRecruitment/lesson_calibration.md
- Updated the image insertion method from
to the sphinx{image} path/to/image :alt: alt text :align: centerformat for better control over image attributes. - Updated the link to the arm2d example.
- Updated the link to the Muscle Modeling tutorial.
- Minor text changes for clarity and flow.
- Updated the image insertion method from
- The_mechanical_elements/index.md
- Marked the tutorial as deleted by adding '(Deleted)' to the title.
- Kept the
caution_old_tutorialcaution box.
- Tutorials.md
- Renamed 'Making_things_move/index' to 'Motion_Capture_Movement/index'.
- core-tutorial-descriptions.txt
- Renamed 'Making things move' to 'Motion Capture Movement'.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A tutorial's plight,
Images updated, text tight,
Knowledge takes new form.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates the Inverse Dynamics of Muscle Systems tutorial with new images, text revisions, and an updated equation insertion method. It also marks the 'The Mechanical Elements' tutorial as deleted and renames 'Making Things Move' to 'Motion Capture movement'. Overall, the changes seem well-organized and contribute to improving the tutorial's clarity and accuracy.
Summary of Findings
- Calibration Model F0 Value: The F0 value in the calibration model was changed from 600 to 400. It's important to verify that this change is intentional and doesn't negatively impact the model's behavior or accuracy. This change has a high potential to affect the results of the tutorial.
- Image Insertion Method: The pull request updates the image insertion method in the markdown files. While this improves the formatting, it's important to ensure that the new method is compatible with all rendering engines and that the images are displayed correctly across different platforms.
Merge Readiness
The pull request includes several updates to the tutorials, including image updates, text revisions, and method updates. Before merging, it's important to ensure that the changes are thoroughly tested and that the tutorials still function as expected. Given the potential impact of the F0 value change in the calibration model, I recommend addressing the high severity comment before merging. I am unable to directly approve this pull request, and users should have others review and approve this code before merging.
|
@JacobAdamsen Is this PR ready to be merged? I now you write that it is not a complete update, but should we merge it anyway? |
- Updated all images
- Change of some text formulations and wordings
- Update of equation insertion method
- Secured all models run and give reasonable results
- NOT a complete update of the tutorial. Could still use extra changes/updates of the general content and use of code
snippets for AnyBody model