Skip to content

Conversation

@Neamar
Copy link
Member

@Neamar Neamar commented Jun 4, 2014

No description provided.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getSavePath.hasMkdir

@Neamar
Copy link
Member Author

Neamar commented Jun 5, 2014

Some afterthoughts on this (i know, mostly my fault):

  • cursor can be renamed to something more clear
  • upload leaks too much abstraction. pushToQueue could simply be uplaod?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(task, cb) => see documentation for async.queue

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e741f6e on save-cursor into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e741f6e on save-cursor into * on master*.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor the file

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e741f6e on save-cursor into * on master*.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, cb

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8d0643a on save-cursor into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8d0643a on save-cursor into * on master*.

Neamar added a commit that referenced this pull request Jun 5, 2014
save, load and renew cursor
@Neamar Neamar merged commit 916d07a into master Jun 5, 2014
@Neamar Neamar deleted the save-cursor branch June 5, 2014 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants