feat: provider.batch_requests() low-level implementation
#2475
Conversation
fubuloubu
left a comment
fubuloubu
left a comment
There was a problem hiding this comment.
@BobTheBuidler had some sort of batching middleware for Brownie, wonder if that might be useful here to look at
|
I had been looking at this issue, and I'm curious. What is the reason for using JSON and the requests library instead of using batch requests from web3.py? https://web3py.readthedocs.io/en/v7.7.0/web3.main.html#batch-requests |
Thanks for pointing this out, let me look into it. |
|
|
||
| return [ | ||
| self._get_result_from_rpc_response(uri, r, raise_on_failure=False) | ||
| for r in response.json() |
There was a problem hiding this comment.
i remember a bug where erigon returned results out of order, so to be safe we can sort by id
| if "jsonrpc" not in request: | ||
| request["jsonrpc"] = "2.0" | ||
| if "id" not in request: | ||
| request["id"] = idx + 1 |
There was a problem hiding this comment.
- enumerate has a second arg for start index
- if we allow id overrides (any good reason for that?), then we need to check there are no duplicates
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
|
This PR was closed because it has been inactive for 35 days. |
4 participants
What I did
implements batch requets at the provider level, not sure about a more top level API yet (maybe something like multicall?)
fixes: #2472
How I did it
How to verify it
Checklist