❤️ a little bit of love#204
Conversation
|
|
||
| @Override | ||
| protected String getResourceName(String name) { | ||
| return "_OpenApi2Quarkus/" + name; // simpleName fails in the tests with Java 17 |
There was a problem hiding this comment.
this was constantly failing on my machine 🤷
There was a problem hiding this comment.
Apparently, this is not completely fixing the issue:
https://github.com/Apicurio/apicurio-codegen/actions/runs/6563277742/job/17827118036
There was a problem hiding this comment.
The problem is that the codegen produces different output with jdk 17 vs 11. So it's failing because the expected output is different from the actual. The pom.xml includes the target java version.
There was a problem hiding this comment.
fixed, we should revisit the "file by file"/"line by line" approach for those tests, but it should be ok for this iteration.
| @@ -0,0 +1,48 @@ | |||
|
|
|||
| package io.apicurio.registry.types; | |||
There was a problem hiding this comment.
Those types are still generated in the io.apicurio.registry.types package, I think this is a bug, cc. @EricWittmann
There was a problem hiding this comment.
Why do you think this is a bug?
There was a problem hiding this comment.
Because I'm generating the output explicitly specifying the target package:
| - name: Release | ||
| uses: softprops/action-gh-release@v1 | ||
| with: | ||
| tag_name: ${{ github.event.inputs.release-version}} | ||
| files: | | ||
| apicurio-codegen-macos | ||
| apicurio-codegen-linux | ||
| apicurio-codegen-win.exe | ||
| - uses: lakto/gren-action@v2.0.0 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| options: '--override' |
There was a problem hiding this comment.
We need to bring this over, but without the attached binary files.
2 participants
Attempt to give a little bit of love to this project:
SimpleNamewas retrievingnullfor .... reasons, now it's possible to run the tests, still they don't succeed 100% of the times 😞