Skip to content

Block solve display map collides on shared item/recipe names (recipe coal-gas overwritten by fluid coal-gas) #113

Description

@ApocDev

Found while writing the module-presets e2e (pre-existing, not caused by #99): the block solve's display map is keyed by bare internal name, so when a recipe and a good share a name the later write wins — recipe coal-gas ("Coal gas from coal") renders its row label as the fluid's display "Coal gas". See app/src/server/block-compute.server.ts around the display-map assembly (~770-787 at the time of finding).

Fix direction: key the map by (kind, name) — or keep separate maps for recipes vs goods — so a recipe row always shows the recipe's own display string. Py has many recipe/product name collisions (the convention of naming a recipe after its main product), so this likely mislabels more rows than the one spotted.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions