Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdded three diagnostic text sensors to the ESPHome config: a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Integrations/ESPHome/Core.yaml (1)
652-655: Explicitly mark the IP sensor as diagnosticESPHome does not automatically set
entity_category: diagnosticforwifi_info.ip_address—it must be explicitly configured. Addentity_category: diagnosticto match the PR objective and ensure consistent behavior across ESPHome versions.Suggested change
- platform: wifi_info ip_address: name: "IP Address" id: wifi_ip + entity_category: diagnostic🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Integrations/ESPHome/Core.yaml` around lines 652 - 655, The IP address sensor definition for wifi_info (the ip_address block defining name "IP Address" and id wifi_ip) needs to explicitly set entity_category to diagnostic; update the ip_address sensor (wifi_info.ip_address) to include entity_category: diagnostic so the sensor is marked as a diagnostic entity across ESPHome versions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Integrations/ESPHome/Core.yaml`:
- Around line 652-655: The IP address sensor definition for wifi_info (the
ip_address block defining name "IP Address" and id wifi_ip) needs to explicitly
set entity_category to diagnostic; update the ip_address sensor
(wifi_info.ip_address) to include entity_category: diagnostic so the sensor is
marked as a diagnostic entity across ESPHome versions.
|
Conflict |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Integrations/ESPHome/Core.yaml (1)
661-667: Consider simplifying the lambda return syntax.The current brace initialization
return {"${version}"};works correctly but is slightly unconventional. A more idiomatic approach would be to return the string directly.♻️ Simplified lambda syntax
lambda: |- - return {"${version}"}; + return "${version}";🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Integrations/ESPHome/Core.yaml` around lines 661 - 667, The lambda for the template sensor apollo_firmware_version uses brace-initialization; change the lambda in the template platform (id: apollo_firmware_version, name: "Apollo Firmware Version") to return the string directly by replacing the current return expression with a direct string return (i.e., return "${version}";) so the lambda is idiomatic and clearer.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Integrations/ESPHome/Core.yaml`:
- Around line 661-667: The lambda for the template sensor
apollo_firmware_version uses brace-initialization; change the lambda in the
template platform (id: apollo_firmware_version, name: "Apollo Firmware Version")
to return the string directly by replacing the current return expression with a
direct string return (i.e., return "${version}";) so the lambda is idiomatic and
clearer.
bharvey88
force-pushed
the
wifi-info-ip-address
branch
from
fa86ec8 to
75caa29
Compare
2 participants
Version: 25.7.18.1
What does this implement/fix?
Adds the device's current IP address as a diagnostic text sensor in Home Assistant.
This makes it easy to identify and connect to individual MSR-1 devices on the network without having to check the router.
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
Summary by CodeRabbit