fix(android): opacity not animating when combined with rotation#40
Merged
janicduplessis merged 1 commit intomainfrom Apr 14, 2026
Merged
fix(android): opacity not animating when combined with rotation#40janicduplessis merged 1 commit intomainfrom
janicduplessis merged 1 commit intomainfrom
Conversation
setBackfaceVisibilityDependantOpacity() resets alpha to 1.0 every frame during rotation animations, overriding animated opacity. Skip the backface check when MASK_OPACITY is set — the opacity animator handles alpha directly in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Android, animating
opacityandrotate(orrotateX/rotateY) simultaneously causes opacity to not animate — the view stays fully opaque.Root cause: React Native's
ReactViewGroup.setBackfaceVisibilityDependantOpacity()resetsalpha = backfaceOpacity(1.0) every frame. EaseView calls this during rotation animations to handle backface visibility, but it overrides the animated opacity value.Fix: Skip the backface alpha reset when
MASK_OPACITYis in the animated bitmask. In that case, the opacity animator manages alpha directly. Applied to all three call sites: first-mount setup, timing animator, and spring animator.Test Plan
yarn lint && yarn test— all 82 tests passopacityandrotatesimultaneously — opacity should now animate correctly