Skip to content

Use BottomSheetModalProps instead of BottomSheetProps as navigation options #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Use BottomSheetModalProps instead of BottomSheetProps as navigation options #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20e7f4f
fix: use BottomSheetModalProps instead of BottomSheetProps
codybrouwers Sep 11, 2022
cf87442
docs: update README
codybrouwers Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const BottomSheet = createBottomSheetNavigator();
<BottomSheet.Screen
name="secondSheet"
component={SecondSheetComponent}
// Can pass any prop from @gorhom/bottom-sheet
// Can pass any prop from @gorhom/bottom-sheet's BottomSheetModal
options={{ snapPoints: [200, "100%"], index: 1 }}
/>
</BottomSheet.Navigator>;
Expand Down Expand Up @@ -61,7 +61,7 @@ Defaults to `['66%']`.

#### Other options

Most props from bottom sheet are exposed as navigation options. See the [@gorhom/bottom-sheet website](https://gorhom.github.io/react-native-bottom-sheet/props) for full documentation.
Most props from `BottomSheetModal` are exposed as navigation options. See the [@gorhom/bottom-sheet website](https://gorhom.github.io/react-native-bottom-sheet/modal/props) for full documentation.

### Navigation helpers

Expand Down
4 changes: 2 additions & 2 deletions src/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { BottomSheetProps } from '@gorhom/bottom-sheet';
import type { BottomSheetModalProps } from '@gorhom/bottom-sheet';
import type {
DefaultNavigatorOptions,
Descriptor,
Expand Down Expand Up @@ -64,7 +64,7 @@ export type BottomSheetNavigationHelpers = NavigationHelpers<
export type BottomSheetNavigationConfig = {};

export type BottomSheetNavigationOptions = Omit<
BottomSheetProps,
BottomSheetModalProps,
// Remove some props that aren't useful as navigation options.
| 'containerHeight'
| 'snapPoints'
Expand Down