Fix OOM when create DefaultAxisValueFormatter #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you. |
hannesa2
changed the title
Collaborator
|
Ohh, I merged too early |
Author
Oh I was about to answer 😅. You can revert it if you want. It's maybe hard to reproduce but I can try and create the PR again. |
Collaborator
|
Yes, maybe it's hard to produce, but it would be nice, to have the OOM situation and see afterward the benefit of this pull request. |
hannesa2
added a commit
that referenced
this pull request
Sep 11, 2025
Revert "Merge pull request #407 from longv/chart-oom"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that when
maxandminare not set, theAxisBase.mDecimalsis updated to infinity and thus cause Out Of Memory asDefaultAxisValueFormattercreate aStringBuffer. There is a similar issue opened in the original repo.Even though we can enable
granularityto prevent this, I think it's better to have a guard in case developers are not aware of thegranularityoption. Hence, I have copied the propose change here.