Skip to content

Use notifyItemInserted instead of notifyDataSetChanged #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannesa2 merged 1 commit into from
May 10, 2021
Merged

Use notifyItemInserted instead of notifyDataSetChanged #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions LogcatCoreLib/src/main/java/info/hannes/logcat/base/LogListAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ import java.util.*

class LogListAdapter(private var completeLogs: MutableList<String>, filter: String) : RecyclerView.Adapter<LogListAdapter.LogViewHolder>() {

private var currentFilter: Array<out String>? = null
var filterLogs: List<String> = ArrayList()
private lateinit var currentFilter: Array<out String>
var filterLogs = mutableListOf<String>()

init {
setFilter(filter)
}

fun setItems(newItems: MutableList<String>) {
completeLogs = newItems
setFilter(*currentFilter!!)
setFilter(*currentFilter)
notifyDataSetChanged()
}

Expand All @@ -41,25 +41,20 @@ class LogListAdapter(private var completeLogs: MutableList<String>, filter: Stri
}
}
include
}
}.toMutableList()
notifyDataSetChanged()
}

fun addLine(addLine: String) {

completeLogs.add(completeLogs.size, addLine)
fun addLine(line: String) {
completeLogs.add(completeLogs.size, line)

filterLogs = completeLogs.filter { line ->
var include = false
currentFilter?.let {
for (filter in it) {
if (!include && line.contains(filter))
include = true
currentFilter.let {
for (filter in it)
if (line.contains(filter)) {
filterLogs.add(filterLogs.size, line)
notifyItemInserted(filterLogs.size - 1)
}
}
include
}
notifyDataSetChanged()
}

/**
Expand Down