Skip to content

RecyclerView: Set stateRestorationPolicy #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannesa2 merged 1 commit into from
May 10, 2021
Merged

RecyclerView: Set stateRestorationPolicy #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions LogcatCoreLib/src/main/java/info/hannes/logcat/base/LogBaseFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,15 @@ abstract class LogBaseFragment : Fragment() {
it.recycledViewPool.setMaxRecycledViews(R.layout.item_log, DEFAULT_MAX_SCRAP)
}
// empty adapter to avoid "E/RecyclerView﹕ No adapter attached; skipping layou..."
logListAdapter = LogListAdapter(mutableListOf(), currentFilter)
logListAdapter = LogListAdapter(mutableListOf(), currentFilter).also {
it.stateRestorationPolicy = RecyclerView.Adapter.StateRestorationPolicy.PREVENT_WHEN_EMPTY
}

logsRecycler.adapter = logListAdapter

setFilter2LogAdapter("")

showLogContent()
showLogContent(savedInstanceState)

setHasOptionsMenu(true)

Expand All @@ -71,16 +74,19 @@ abstract class LogBaseFragment : Fragment() {
return view
}

private fun showLogContent() {
private fun showLogContent(savedInstanceState: Bundle?) {
lifecycle.coroutineScope.launch(Dispatchers.Main) {
val logEntries = withContext(Dispatchers.Default) {
readLogFile()
}
logListAdapter?.setItems(logEntries)
logListAdapter?.itemCount?.minus(1)?.let { logsRecycler.scrollToPosition(it) }

if (savedInstanceState == null) {
logListAdapter?.itemCount?.minus(1)?.let { logsRecycler.scrollToPosition(it) }
}

if (live) {
Handler(Looper.getMainLooper()).postDelayed({ showLogContent() }, 1000)
Handler(Looper.getMainLooper()).postDelayed({ showLogContent(null) }, 1000)
}
}
}
Expand Down Expand Up @@ -140,7 +146,7 @@ abstract class LogBaseFragment : Fragment() {
switch.setOnCheckedChangeListener { _, isChecked ->
live = isChecked
if (live)
showLogContent()
showLogContent(null)
}
super.onCreateOptionsMenu(menu, inflater)
}
Expand Down Expand Up @@ -169,7 +175,7 @@ abstract class LogBaseFragment : Fragment() {
}
R.id.menu_clear -> {
clearLog()
showLogContent()
showLogContent(null)
}
R.id.menu_show_verbose -> {
item.isChecked = true
Expand Down