-
Notifications
You must be signed in to change notification settings - Fork 109
chore: translate row content #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the AI translation utility for table rows to only use the translated content field from the API response and simplify how the final translation string is constructed. Sequence diagram for updated generateAITranslateForRow translation flowsequenceDiagram
participant Caller
participant HttpService
participant AITranslateAPI
Caller->>HttpService: generateAITranslateForRow(workspaceId, payload)
HttpService->>AITranslateAPI: POST /ai/translate_row with payload
AITranslateAPI-->>HttpService: payloadResponse with items
Note over HttpService: items: [{ content, ...otherFields }]
loop For each item in payloadResponse.items
HttpService->>HttpService: extract item.content
HttpService->>HttpService: filter out empty content
end
HttpService->>HttpService: join contents with ", "
HttpService-->>Caller: translatedRowContentString
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The separator between translated rows changed from a newline (
'\n') to', ', which may affect any consumer logic or display that relied on line breaks—confirm this formatting change is intentional. - The new implementation assumes every item has a
contentfield; if this shape isn’t guaranteed by the API, consider adding a more defensive access pattern or a runtime check to avoid silent data loss.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The separator between translated rows changed from a newline (`'\n'`) to `', '`, which may affect any consumer logic or display that relied on line breaks—confirm this formatting change is intentional.
- The new implementation assumes every item has a `content` field; if this shape isn’t guaranteed by the API, consider adding a more defensive access pattern or a runtime check to avoid silent data loss.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
General
Testing
Feature-Specific
Summary by Sourcery
Simplify how translated row content is aggregated from the AI translation response.
Bug Fixes:
Enhancements: