chore: improve number format display strings#1705
Merged
appflowy merged 1 commit intoAppFlowy-IO:mainfrom Jan 20, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1705 +/- ##
===========================================
- Coverage 38.42% 16.47% -21.95%
===========================================
Files 413 292 -121
Lines 19390 12698 -6692
===========================================
- Hits 7450 2092 -5358
+ Misses 11940 10606 -1334
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
47bc28f to
c890378
Compare
Collaborator
Author
|
Or should we localize them? |
Contributor
|
Wow, that's awesome! |
Contributor
I check out how notion handles this. It seems the same as AppFlowy. |
Collaborator
Author
Awesome, then I think this is good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.