Skip to content

chore: improve number format display strings#1705

Merged
appflowy merged 1 commit intoAppFlowy-IO:mainfrom
richardshiue:translations
Jan 20, 2023
Merged

chore: improve number format display strings#1705
appflowy merged 1 commit intoAppFlowy-IO:mainfrom
richardshiue:translations

Conversation

@richardshiue
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2023

Codecov Report

Merging #1705 (c890378) into main (834152d) will decrease coverage by 21.94%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1705       +/-   ##
===========================================
- Coverage   38.42%   16.47%   -21.95%     
===========================================
  Files         413      292      -121     
  Lines       19390    12698     -6692     
===========================================
- Hits         7450     2092     -5358     
+ Misses      11940    10606     -1334     
Flag Coverage Δ
appflowy 16.47% <ø> (ø)
appflowy_editor ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lication/field/type_option/number_format_bloc.dart 0.00% <ø> (ø)
...es/appflowy_editor/lib/src/core/document/path.dart
...kages/appflowy_editor/lib/src/flutter/overlay.dart
...appflowy_editor/lib/src/service/input_service.dart
...itor/lib/src/render/image/image_upload_widget.dart
...flowy_editor/lib/src/l10n/intl/messages_ru-RU.dart
...r/lib/src/core/legacy/built_in_attribute_keys.dart
...lib/src/render/rich_text/built_in_text_widget.dart
...flowy_editor/lib/src/l10n/intl/messages_pl-PL.dart
...flowy_editor/lib/src/l10n/intl/messages_zh-TW.dart
... and 112 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@richardshiue
Copy link
Collaborator Author

Or should we localize them?

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2023

CLA assistant check
All committers have signed the CLA.

@appflowy
Copy link
Contributor

Wow, that's awesome!

@appflowy
Copy link
Contributor

Or should we localize them?

I check out how notion handles this. It seems the same as AppFlowy.

@richardshiue
Copy link
Collaborator Author

Or should we localize them?

I check out how notion handles this. It seems the same as AppFlowy.

Awesome, then I think this is good to go.

@appflowy appflowy merged commit 0100305 into AppFlowy-IO:main Jan 20, 2023
@richardshiue richardshiue deleted the translations branch January 20, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants