Skip to content

fix: use window_manager to set minimum window size#1791

Merged
LucasXu0 merged 4 commits intoAppFlowy-IO:mainfrom
Merrit:linux_window_scale
Feb 9, 2023
Merged

fix: use window_manager to set minimum window size#1791
LucasXu0 merged 4 commits intoAppFlowy-IO:mainfrom
Merrit:linux_window_scale

Conversation

@Merrit
Copy link
Contributor

@Merrit Merrit commented Feb 3, 2023

Resolves #762
Resolves #1559

Fixes being unable to resize the tiny default window on Linux.

Having window_manager available also gives us the ability to do many window-related operations in the future if desired.

If this is merged I'd next suggest we look at the ability to remember window size & position between launches.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2023

CLA assistant check
All committers have signed the CLA.

@LucasXu0 LucasXu0 self-requested a review February 7, 2023 02:13
@Merrit Merrit force-pushed the linux_window_scale branch from 9727eea to 7522667 Compare February 8, 2023 18:41
@LucasXu0
Copy link
Collaborator

LucasXu0 commented Feb 9, 2023

windowManager.setMinimumSize(const Size(minWidth, minWidth / ratio)); will cause a crash on macOS.

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Feb 9, 2023

I have addressed the problem. The width and height should be integers in this case.

@codecov-commenter
Copy link

Codecov Report

Merging #1791 (50ead3f) into main (84ea888) will decrease coverage by 21.84%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main    #1791       +/-   ##
===========================================
- Coverage   38.01%   16.18%   -21.84%     
===========================================
  Files         423      301      -122     
  Lines       19882    12966     -6916     
===========================================
- Hits         7559     2098     -5461     
+ Misses      12323    10868     -1455     
Flag Coverage Δ
appflowy 16.18% <ø> (-0.01%) ⬇️
appflowy_editor ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/app_flowy/lib/startup/tasks/app_widget.dart 85.71% <ø> (-0.40%) ⬇️
..._editor/lib/src/render/rich_text/heading_text.dart
...wy_editor/lib/src/commands/text/text_commands.dart
...lowy_editor/lib/src/service/selection_service.dart
...editor/lib/src/render/color_menu/color_picker.dart
...tor/lib/src/service/context_menu/context_menu.dart
.../appflowy_editor/lib/src/infra/html_converter.dart
...ns/markdown/decoder/document_markdown_decoder.dart
...owy_editor/lib/src/render/rich_text/rich_text.dart
...ppflowy_editor/lib/src/service/scroll_service.dart
... and 113 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LucasXu0 LucasXu0 merged commit 6b8c7d7 into AppFlowy-IO:main Feb 9, 2023
@annieappflowy annieappflowy added the bug Something isn't working label Feb 9, 2023
@annieappflowy annieappflowy added this to the v0.1.0 milestone Feb 9, 2023
@Merrit Merrit deleted the linux_window_scale branch February 10, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug] Scaling error 4k monitor Linux [Bug] App doesn't open fully / cant be resized when using fractional scaling on linux

5 participants