fix: use window_manager to set minimum window size#1791
Merged
LucasXu0 merged 4 commits intoAppFlowy-IO:mainfrom Feb 9, 2023
Merged
fix: use window_manager to set minimum window size#1791LucasXu0 merged 4 commits intoAppFlowy-IO:mainfrom
LucasXu0 merged 4 commits intoAppFlowy-IO:mainfrom
Conversation
LucasXu0
reviewed
Feb 7, 2023
9727eea to
7522667
Compare
Was meant to be setMinimumSize not setSize
Collaborator
|
|
Collaborator
|
I have addressed the problem. The width and height should be integers in this case. |
7522667 to
50ead3f
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1791 +/- ##
===========================================
- Coverage 38.01% 16.18% -21.84%
===========================================
Files 423 301 -122
Lines 19882 12966 -6916
===========================================
- Hits 7559 2098 -5461
+ Misses 12323 10868 -1455
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #762
Resolves #1559
Fixes being unable to resize the tiny default window on Linux.
Having
window_manageravailable also gives us the ability to do many window-related operations in the future if desired.If this is merged I'd next suggest we look at the ability to remember window size & position between launches.