Skip to content

Improvement for cover plugin #1928#1981

Merged
LucasXu0 merged 9 commits intoAppFlowy-IO:mainfrom
rizwan3395:improvement_for_cover_plugin_1928
Mar 15, 2023
Merged

Improvement for cover plugin #1928#1981
LucasXu0 merged 9 commits intoAppFlowy-IO:mainfrom
rizwan3395:improvement_for_cover_plugin_1928

Conversation

@rizwan3395
Copy link
Contributor

Description

Improve user experience for cover plugin. Added the support to add emoji and use images from URL as cover.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tap add icon. A menu pops up. Select emoji. Menu closes and displays emoji.
  • Tap Emoji icon. A menu pops up. Select emoji. Menu closes and emoji updates.
  • Tap Emoji icon. A menu pops up. Tap remove icon. Menu closes and emoji gets deleted
  • Tap change cover. Tap add image box. The dialog changes. Paste a valid URL. Image preview shows. Tap Save to gallery previous dialog displays and images is added to the gallery.
  • Tap change cover. Tap add image box. The dialog changes. Paste a in valid URL. No previews show. Error message gets displayed
  • Tap change cover. Tap add image box. The dialog changes. Tap pick from files. File browser opens.. Select any image. Displays preview. Tap Tap Save to gallery previous dialog displays and images is added to the gallery.
  • Tap Back the dialog goes back to gallery
  • When an image is picked and being previewed. Tap Close icon. The image preview gets deleted

Checklist:

  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #1981 (bcc55cc) into main (79a43de) will decrease coverage by 0.43%.
The diff coverage is 7.30%.

❗ Current head bcc55cc differs from pull request most recent head 4968812. Consider uploading reports for the commit 4968812 to get more accurate results

@@            Coverage Diff             @@
##             main    #1981      +/-   ##
==========================================
- Coverage   15.89%   15.47%   -0.43%     
==========================================
  Files         316      329      +13     
  Lines       14055    14709     +654     
==========================================
+ Hits         2234     2276      +42     
- Misses      11821    12433     +612     
Flag Coverage Δ
appflowy 15.47% <7.30%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../document/application/cover_image_picker_bloc.dart 0.00% <0.00%> (ø)
...esentation/plugins/cover/change_cover_popover.dart 0.00% <0.00%> (ø)
...presentation/plugins/cover/cover_image_picker.dart 0.00% <0.00%> (ø)
...ment/presentation/plugins/cover/emoji_popover.dart 0.00% <0.00%> (ø)
...cument/presentation/plugins/cover/icon_widget.dart 0.00% <0.00%> (ø)
.../presentation/plugins/cover/cover_node_widget.dart 30.18% <22.41%> (+9.31%) ⬆️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LucasXu0
Copy link
Collaborator

Hey, @rizwan3395. I added some comments. Pls take a look.

@LucasXu0
Copy link
Collaborator

Closes #1928

@rizwan3395 rizwan3395 force-pushed the improvement_for_cover_plugin_1928 branch from e572fd2 to 9a51183 Compare March 14, 2023 18:23
@rizwan3395
Copy link
Contributor Author

Hi @LucasXu0 done the changes you mentioned. Let me know if there is something else to change.

@LucasXu0 LucasXu0 merged commit 4c0168d into AppFlowy-IO:main Mar 15, 2023
@annieappflowy annieappflowy added improvements improvements on an existing feature editor features related to the rich-text editor labels Mar 15, 2023
@annieappflowy annieappflowy added this to the v0.1.1 milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editor features related to the rich-text editor improvements improvements on an existing feature

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants