Improvement for cover plugin #1928#1981
Merged
LucasXu0 merged 9 commits intoAppFlowy-IO:mainfrom Mar 15, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1981 +/- ##
==========================================
- Coverage 15.89% 15.47% -0.43%
==========================================
Files 316 329 +13
Lines 14055 14709 +654
==========================================
+ Hits 2234 2276 +42
- Misses 11821 12433 +612
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
LucasXu0
reviewed
Mar 14, 2023
frontend/appflowy_flutter/lib/plugins/document/application/cover_image_picker_bloc.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/document/application/cover_image_picker_bloc.dart
Show resolved
Hide resolved
LucasXu0
reviewed
Mar 14, 2023
frontend/appflowy_flutter/lib/plugins/document/application/cover_image_picker_bloc.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/document/application/cover_image_picker_bloc.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/document/application/cover_image_picker_bloc.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/document/application/cover_image_picker_bloc.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/document/application/cover_image_picker_bloc.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/document/application/cover_image_picker_bloc.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/document/application/cover_image_picker_bloc.dart
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/document/application/cover_image_picker_bloc.dart
Outdated
Show resolved
Hide resolved
...end/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/cover_image_picker.dart
Outdated
Show resolved
Hide resolved
Collaborator
|
Hey, @rizwan3395. I added some comments. Pls take a look. |
Collaborator
|
Closes #1928 |
e572fd2 to
9a51183
Compare
Contributor
Author
|
Hi @LucasXu0 done the changes you mentioned. Let me know if there is something else to change. |
LucasXu0
reviewed
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve user experience for cover plugin. Added the support to add emoji and use images from URL as cover.
Type of change
How Has This Been Tested?
add icon. A menu pops up. Select emoji. Menu closes and displays emoji.remove icon. Menu closes and emoji gets deletedchange cover. Tap add image box. The dialog changes. Paste a valid URL. Image preview shows. TapSave to galleryprevious dialog displays and images is added to the gallery.change cover. Tap add image box. The dialog changes. Paste a in valid URL. No previews show. Error message gets displayedchange cover. Tap add image box. The dialog changes. Tappick from files. File browser opens.. Select any image. Displays preview. Tap TapSave to galleryprevious dialog displays and images is added to the gallery.Backthe dialog goes back to galleryChecklist: