feat: init flowy document 2#2248
Merged
LucasXu0 merged 5 commits intoAppFlowy-IO:developfrom Apr 13, 2023
Merged
Conversation
LucasXu0
force-pushed
the
flowy-document2
branch
from
328c105 to
fa9a2ca
Compare
LucasXu0
force-pushed
the
flowy-document2
branch
from
fa9a2ca to
4e89703
Compare
appflowy
reviewed
Apr 12, 2023
| collab = { git = "https://github.com/AppFlowy-IO/AppFlowy-Collab" } | ||
| collab-folder = { git = "https://github.com/AppFlowy-IO/AppFlowy-Collab" } | ||
| collab-persistence = { git = "https://github.com/AppFlowy-IO/AppFlowy-Collab" } | ||
| collab = { git = "https://github.com/AppFlowy-IO/AppFlowy-Collab", branch = "main" } |
Contributor
There was a problem hiding this comment.
the default branch will be the main branch. So no need to mark the branch.
appflowy
reviewed
Apr 12, 2023
| pub page_id: String, | ||
|
|
||
| #[pb(index = 2)] | ||
| pub blocks: BlocksPB, |
Contributor
There was a problem hiding this comment.
I think BlockMap would be better
LucasXu0
force-pushed
the
flowy-document2
branch
2 times, most recently
from
329e830 to
d8ad31b
Compare
LucasXu0
force-pushed
the
flowy-document2
branch
from
d8ad31b to
e76c796
Compare
qinluhe
reviewed
Apr 13, 2023
| children: text_0_children_id.clone(), | ||
| external_id: None, | ||
| external_type: None, | ||
| data: HashMap::new(), |
Contributor
There was a problem hiding this comment.
The data will be like this?
data: {
delta: vec![]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR. Only for reference.
Feature Preview
PR Checklist