Skip to content

chore: some ui improvements#2791

Merged
appflowy merged 9 commits intoAppFlowy-IO:mainfrom
richardshiue:ui
Jun 16, 2023
Merged

chore: some ui improvements#2791
appflowy merged 9 commits intoAppFlowy-IO:mainfrom
richardshiue:ui

Conversation

@richardshiue
Copy link
Collaborator

@richardshiue richardshiue commented Jun 13, 2023

A couple of UI improvements in the grid UI:

  • Remove hack for Text overflow with ellipsis is weird and ugly by design flutter/flutter#18761 . Due to the removal of the hack that adds a zero-width space before every single character, the integration test will now find more widgets with the text "Read me", presumably in the sidebar where FlowyText is used. Therefore, I'm changing this findOneWidget to findWidgets.
  • Add icons for hide and delete field
    image
  • Slightly bump up the height of select option editor to make everything in the popup fit by default
  • Fixed padding on date and time format buttons

fixes #2761

Feature Preview


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #2791 (97ab14c) into main (14dee6b) will increase coverage by 44.33%.
The diff coverage is 60.00%.

@@             Coverage Diff             @@
##             main    #2791       +/-   ##
===========================================
+ Coverage   12.99%   57.33%   +44.33%     
===========================================
  Files         401      401               
  Lines       18672    18684       +12     
===========================================
+ Hits         2427    10712     +8285     
+ Misses      16245     7972     -8273     
Flag Coverage Δ
appflowy_flutter_integrateion_test 54.97% <60.00%> (?)
appflowy_flutter_unit_test 13.00% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ation/widgets/header/field_type_option_editor.dart 100.00% <ø> (+100.00%) ⬆️
...tion/widgets/header/type_option/select_option.dart 38.29% <0.00%> (+36.17%) ⬆️
...grid/presentation/widgets/header/field_editor.dart 73.17% <40.00%> (+73.17%) ⬆️
...tation/widgets/header/field_cell_action_sheet.dart 100.00% <100.00%> (+100.00%) ⬆️
.../presentation/widgets/header/type_option/date.dart 38.63% <100.00%> (+37.91%) ⬆️
...cells/select_option_cell/select_option_editor.dart 77.41% <100.00%> (+77.41%) ⬆️

... and 275 files with indirect coverage changes

@appflowy
Copy link
Contributor

I created a integration test for creating a option in single select cell. Maybe you can try to add more tests.

create_option.mp4.mov

hyj1204 and others added 5 commits June 15, 2023 09:16
* feat: add language selector on welcome page

* feat: add hover effect and refactor layout

* test: add basic languge selector testing

* chore: increate place holder width

* fix: add catch error for setLocale and finish the testing

* chore: update comment

* feat: refactor the skip login in page and add tests

---------

Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>
* chore: create orphan view handler

* feat: save icon url and cover url in view

* feat: implement emoji picker UI

* chore: config ui

* chore: config ui again

* chore: replace RowPB with RowMetaPB to exposing more row information

* fix: compile error

* feat: show emoji in row

* chore: update

* test: insert emoji test

* test: add update emoji test

* test: add remove emoji test

* test: add create field tests

* test: add create row and delete row integration tests

* test: add create row from row menu

* test: document in row detail page

* test: delete, duplicate row in row detail page

* test: check the row count displayed in grid page

* test: rename existing field in grid page

* test: update field type of exisiting field in grid page

* test: delete field test

* test: add duplicate field test

* test: add hide field test

* test: add edit text cell test

* test: add insert text to text cell test

* test: add edit number cell test

* test: add edit multiple number cells

* test: add edit checkbox cell test

* feat: integrate editor into database row

* test: add edit create time and last edit time cell test

* test: add edit date cell by selecting a date test

* chore: remove unused code

* chore: update checklist bg color

* test: add update database layout test

---------

Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>
@richardshiue
Copy link
Collaborator Author

I created a integration test for creating a option in single select cell. Maybe you can try to add more tests.
create_option.mp4.mov

Of course!

@appflowy appflowy merged commit efc857d into AppFlowy-IO:main Jun 16, 2023
qinluhe pushed a commit to Ascarbek/AppFlowy that referenced this pull request Jun 16, 2023
* chore: some ui improvements

* fix: integration test

* feat: language selector on welcome page (AppFlowy-IO#2796)

* feat: add language selector on welcome page

* feat: add hover effect and refactor layout

* test: add basic languge selector testing

* chore: increate place holder width

* fix: add catch error for setLocale and finish the testing

* chore: update comment

* feat: refactor the skip login in page and add tests

---------

Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>

* feat: row document (AppFlowy-IO#2792)

* chore: create orphan view handler

* feat: save icon url and cover url in view

* feat: implement emoji picker UI

* chore: config ui

* chore: config ui again

* chore: replace RowPB with RowMetaPB to exposing more row information

* fix: compile error

* feat: show emoji in row

* chore: update

* test: insert emoji test

* test: add update emoji test

* test: add remove emoji test

* test: add create field tests

* test: add create row and delete row integration tests

* test: add create row from row menu

* test: document in row detail page

* test: delete, duplicate row in row detail page

* test: check the row count displayed in grid page

* test: rename existing field in grid page

* test: update field type of exisiting field in grid page

* test: delete field test

* test: add duplicate field test

* test: add hide field test

* test: add edit text cell test

* test: add insert text to text cell test

* test: add edit number cell test

* test: add edit multiple number cells

* test: add edit checkbox cell test

* feat: integrate editor into database row

* test: add edit create time and last edit time cell test

* test: add edit date cell by selecting a date test

* chore: remove unused code

* chore: update checklist bg color

* test: add update database layout test

---------

Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>

* test: fix test

* test: add create select option test

---------

Co-authored-by: Yijing Huang <hyj891204@gmail.com>
Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>
Co-authored-by: Nathan.fooo <86001920+appflowy@users.noreply.github.com>
Co-authored-by: nathan <nathan@appflowy.io>
@richardshiue richardshiue deleted the ui branch June 21, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] the property action menu needs design polish

4 participants