Skip to content

Support document multiple instance and change doc_id from String to &str#2808

Merged
qinluhe merged 15 commits intoAppFlowy-IO:mainfrom
qinluhe:fix/document-multiple-instance
Jun 17, 2023
Merged

Support document multiple instance and change doc_id from String to &str#2808
qinluhe merged 15 commits intoAppFlowy-IO:mainfrom
qinluhe:fix/document-multiple-instance

Conversation

@qinluhe
Copy link
Contributor

@qinluhe qinluhe commented Jun 15, 2023

Feature Preview

  • Support multiple document instances
  • Change doc_id from String to &str
  • Support multiple menu to respond arrow key events
  • Fixed emoji caret position
  • Fixed paste didn't work bugs

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #2808 (0ab4904) into main (d986e01) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2808   +/-   ##
=======================================
  Coverage   57.33%   57.33%           
=======================================
  Files         401      401           
  Lines       18684    18684           
=======================================
  Hits        10712    10712           
  Misses       7972     7972           
Flag Coverage Δ
appflowy_flutter_integrateion_test 54.97% <ø> (ø)
appflowy_flutter_unit_test 13.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@qinluhe qinluhe marked this pull request as ready for review June 16, 2023 11:30
@qinluhe qinluhe force-pushed the fix/document-multiple-instance branch from fa29083 to 937bade Compare June 16, 2023 11:45
@qinluhe qinluhe requested a review from LucasXu0 June 16, 2023 11:53
@qinluhe qinluhe force-pushed the fix/document-multiple-instance branch from 937bade to 0ab4904 Compare June 16, 2023 12:34
@qinluhe qinluhe merged commit 177f7c4 into AppFlowy-IO:main Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant