fix: overlapped scrollbar in calendar#3075
Merged
appflowy merged 5 commits intoAppFlowy-IO:mainfrom Aug 8, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3075 +/- ##
==========================================
- Coverage 67.89% 67.83% -0.07%
==========================================
Files 443 443
Lines 21103 21107 +4
==========================================
- Hits 14328 14317 -11
- Misses 6775 6790 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs #3073
resolves #2618
I've removed the largest scrollbar in the calendar so that only the scrollbar in each cell will be displayed. I'd love to get some usability feedback.
Echoing my comment in #2618, since
MonthViewdoesn't expose a scrollController, we cannot use the existing thick scrollbar as seen in the grid.Feature Preview
PR Checklist