Skip to content

feat: improve CJK IME support#3278

Merged
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
LucasXu0:cjk_ime
Aug 28, 2023
Merged

feat: improve CJK IME support#3278
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
LucasXu0:cjk_ime

Conversation

@LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Aug 25, 2023

Feature Preview

CJK IME preview

Windows

https://www.loom.com/share/60449cc32e1d4897a2b7e2f6e68e62b1

macOS

https://www.loom.com/share/292f65c1fd9240b389f881388b6bb871

closes #3227
closes #3193
closes #3173
closes #3155
closes #3132
closes #3060
closes #2896
closes #2909
closes #2769
closes #2768
closes #2666
closes #2331
closes #2222


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #3278 (6a9f7d8) into main (255f305) will increase coverage by 56.17%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #3278       +/-   ##
===========================================
+ Coverage   12.61%   68.78%   +56.17%     
===========================================
  Files         468      468               
  Lines       21684    21697       +13     
===========================================
+ Hits         2735    14924    +12189     
+ Misses      18949     6773    -12176     
Flag Coverage Δ
appflowy_flutter_integrateion_test 66.60% <ø> (?)
appflowy_flutter_unit_test 12.62% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 364 files with indirect coverage changes

@LucasXu0 LucasXu0 merged commit 41ec2d9 into AppFlowy-IO:main Aug 28, 2023
zoli pushed a commit to zoli/AppFlowy that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment