Fixed Issue no #3426 by aryan-more · Pull Request #3440 · AppFlowy-IO/AppFlowy

aryan-more · 2023-09-19T06:51:43Z

fixes #3426

Added Padding Between Edit Textfield and Select Type Dropdown

[✅ ] My code adheres to the AppFlowy Style Guide
[✅ ] I've listed at least one issue that this PR fixes in the description above.
[❌ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
[✅ ] All existing tests are passing.

CLAassistant · 2023-09-19T06:51:47Z

All committers have signed the CLA.

codecov · 2023-09-19T07:22:45Z

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (6ba7fc0) 69.52% compared to head (8fb690a) 69.54%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3440      +/-   ##
==========================================
+ Coverage   69.52%   69.54%   +0.01%     
==========================================
  Files         501      501              
  Lines       22949    22953       +4     
==========================================
+ Hits        15956    15962       +6     
+ Misses       6993     6991       -2

Flag	Coverage Δ
appflowy_flutter_integrateion_test	`67.39% <100.00%> (+0.01%)`	⬆️
appflowy_flutter_unit_test	`12.79% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...grid/presentation/widgets/header/field_editor.dart	`90.59% <100.00%> (+0.33%)`	⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

frontend/appflowy_flutter/pubspec.lock

richardshiue

A good start! A few suggestions:

We have a VSpace class that you can use which is a bit more readable.
The height of 8 and adding the 4 pre-exisiting whitespace to the top and bottom, makes this 16 in total, not 12
If there aren't buttons to the bottom (see the primary field or the "Name" field in a new grid), the whitespace shouldn't be added.

aryan-more · 2023-09-21T10:47:51Z

@richardshiue Thanks for suggesting the VSpace Widget. I added VSpace only to the Type Selection Dropdown since I noticed that the other two widgets already have padding, which is why I didn't add it to them.

richardshiue · 2023-09-21T11:04:11Z

Did you test in the row detail page as well?

aryan-more · 2023-09-21T15:31:46Z

@richardshiue i was searching where does those two delete and hide button shows up i didn't able to find them ,thanks for sharing screenshot and it's now fixed

richardshiue

LGTM

richardshiue · 2023-09-22T03:15:30Z

Merged, thanks for contributing!

* Fixed Issue no #3426 * Reversed the pubspec.lock mistaken update * FIXED PADDING * Fixed Padding issue on calender field edit popup

* chore: update client-api rev * chore: update collab rev id * feat: add sign_in_request and import shared entity * feat: added to userworkspace from af_workspace * chore: add script to update the client-api rev id * chore: update client-api rev * feat: add workspaces api * feat: added check user * chore: config * chore: update client_api version * chore: ws connect * chore: ws connect * chore: update crate versions * chore: rename event * chore: update client-appi * chore: set appflowy cloud env * chore: add env template * chore: update env name * docs: update docs * fix: check_user * feat: impl sign_in_with_url * feat: add file storage placeholders * chore: update client-api * chore: disable test * feat: impl workspace add and remove * chore: sign up test * feat: select cover image on upload (#3488) * fix: close popover after item selection in settings view (#3362) * fix: close popover after item selection in settings view * fix: add missing await before closing popover * fix: find popover container by context instead of passing controllers around * fix: add requested changes * feat: close text direction settings popups after selection * fix: clean up * fix: restore theme value dropdown as StatefulWidget * feat: openai and stabilityai integration (#3439) * chore: create trait * test: add tests * chore: remove log * chore: disable log * chore: checklist ux flow redesign (#3418) * chore: ux flow redesign * chore: remove unused imports * fix: allow creation of tasks of the same name * chore: apply code suggestions from Mathias * fix: add padding below field title text field (#3440) * Fixed Issue no #3426 * Reversed the pubspec.lock mistaken update * FIXED PADDING * Fixed Padding issue on calender field edit popup * chore: rename package name (#3501) * fix: right icon size sam as left one (#3494) * feat: enable removing user icon (#3487) * feat: enable removing user icon * fix: generate to true * fix: review comments * fix: more review comments * fix: integration test and final changes * fix: made cursor grab and background color when hovering on Appearance Options Buttons (#3498) * chore: calendar UI polish (#3484) * chore: update calendar theming * feat: add event popup editor * chore: new event button redesign and add card shadows * chore: unscheduled events button * chore: event title text field * fix: focus node double dispose * chore: show popover when create new event * test: integrate some tests for integration testing purposes * fix: some fixes and more integration tests * chore: add more space between font item and font menu * feat: add reset font button in toolbar * feat: only show text direction toolbar item when RTL is enabled * fix: unable to change RTL of heading block * test: add integration test for ltr/rtl mode * chore: update inlang project settings (#3441) * feat: using script to update the collab source. (#3508) * chore: add script * chore: update script * chore: update bytes version * chore: submit lock file * chore: update test * chore: update test * chore: bump version * chore: update * ci: fix * ci: fix * chore: update commit id * chore: update commit id * chore: update commit id * fix: is cloud enable --------- Co-authored-by: Fu Zi Xiang <speed2exe@live.com.sg> Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com> Co-authored-by: Vincenzo De Petris <37916223+vincendep@users.noreply.github.com> Co-authored-by: Richard Shiue <71320345+richardshiue@users.noreply.github.com> Co-authored-by: Aryan More <61151896+aryan-more@users.noreply.github.com> Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io> Co-authored-by: Lakhan Baheti <94619783+1akhanBaheti@users.noreply.github.com> Co-authored-by: Nitin-Poojary <70025277+Nitin-Poojary@users.noreply.github.com> Co-authored-by: Jannes Blobel <72493222+jannesblobel@users.noreply.github.com>

* chore: update client-api rev * chore: update collab rev id * feat: add sign_in_request and import shared entity * feat: added to userworkspace from af_workspace * chore: add script to update the client-api rev id * chore: update client-api rev * feat: add workspaces api * feat: added check user * chore: config * chore: update client_api version * chore: ws connect * chore: ws connect * chore: update crate versions * chore: rename event * chore: update client-appi * chore: set appflowy cloud env * chore: add env template * chore: update env name * docs: update docs * fix: check_user * feat: impl sign_in_with_url * feat: add file storage placeholders * chore: update client-api * chore: disable test * feat: impl workspace add and remove * chore: sign up test * feat: select cover image on upload (AppFlowy-IO#3488) * fix: close popover after item selection in settings view (AppFlowy-IO#3362) * fix: close popover after item selection in settings view * fix: add missing await before closing popover * fix: find popover container by context instead of passing controllers around * fix: add requested changes * feat: close text direction settings popups after selection * fix: clean up * fix: restore theme value dropdown as StatefulWidget * feat: openai and stabilityai integration (AppFlowy-IO#3439) * chore: create trait * test: add tests * chore: remove log * chore: disable log * chore: checklist ux flow redesign (AppFlowy-IO#3418) * chore: ux flow redesign * chore: remove unused imports * fix: allow creation of tasks of the same name * chore: apply code suggestions from Mathias * fix: add padding below field title text field (AppFlowy-IO#3440) * Fixed Issue no AppFlowy-IO#3426 * Reversed the pubspec.lock mistaken update * FIXED PADDING * Fixed Padding issue on calender field edit popup * chore: rename package name (AppFlowy-IO#3501) * fix: right icon size sam as left one (AppFlowy-IO#3494) * feat: enable removing user icon (AppFlowy-IO#3487) * feat: enable removing user icon * fix: generate to true * fix: review comments * fix: more review comments * fix: integration test and final changes * fix: made cursor grab and background color when hovering on Appearance Options Buttons (AppFlowy-IO#3498) * chore: calendar UI polish (AppFlowy-IO#3484) * chore: update calendar theming * feat: add event popup editor * chore: new event button redesign and add card shadows * chore: unscheduled events button * chore: event title text field * fix: focus node double dispose * chore: show popover when create new event * test: integrate some tests for integration testing purposes * fix: some fixes and more integration tests * chore: add more space between font item and font menu * feat: add reset font button in toolbar * feat: only show text direction toolbar item when RTL is enabled * fix: unable to change RTL of heading block * test: add integration test for ltr/rtl mode * chore: update inlang project settings (AppFlowy-IO#3441) * feat: using script to update the collab source. (AppFlowy-IO#3508) * chore: add script * chore: update script * chore: update bytes version * chore: submit lock file * chore: update test * chore: update test * chore: bump version * chore: update * ci: fix * ci: fix * chore: update commit id * chore: update commit id * chore: update commit id * fix: is cloud enable --------- Co-authored-by: Fu Zi Xiang <speed2exe@live.com.sg> Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com> Co-authored-by: Vincenzo De Petris <37916223+vincendep@users.noreply.github.com> Co-authored-by: Richard Shiue <71320345+richardshiue@users.noreply.github.com> Co-authored-by: Aryan More <61151896+aryan-more@users.noreply.github.com> Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io> Co-authored-by: Lakhan Baheti <94619783+1akhanBaheti@users.noreply.github.com> Co-authored-by: Nitin-Poojary <70025277+Nitin-Poojary@users.noreply.github.com> Co-authored-by: Jannes Blobel <72493222+jannesblobel@users.noreply.github.com>

Fixed Issue no AppFlowy-IO#3426

d3a27fa

LucasXu0 reviewed Sep 19, 2023

View reviewed changes

frontend/appflowy_flutter/pubspec.lock Outdated Show resolved Hide resolved

Reversed the pubspec.lock mistaken update

7b58cdf

richardshiue requested changes Sep 20, 2023

View reviewed changes

aryan-more and others added 2 commits September 20, 2023 10:29

Merge branch 'AppFlowy-IO:main' into main

c806927

FIXED PADDING

1db7094

Fixed Padding issue on calender field edit popup

f19d704

Merge branch 'AppFlowy-IO:main' into main

8fb690a

richardshiue approved these changes Sep 22, 2023

View reviewed changes

richardshiue merged commit d5f8ce5 into AppFlowy-IO:main Sep 22, 2023

appflowy pushed a commit that referenced this pull request Sep 25, 2023

fix: add padding below field title text field (#3440)

17f405f

* Fixed Issue no #3426 * Reversed the pubspec.lock mistaken update * FIXED PADDING * Fixed Padding issue on calender field edit popup

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed Issue no #3426#3440

Fixed Issue no #3426#3440
richardshiue merged 6 commits intoAppFlowy-IO:mainfrom
aryan-more:main

aryan-more commented Sep 19, 2023

Uh oh!

CLAassistant commented Sep 19, 2023 •

edited

Loading

Uh oh!

codecov bot commented Sep 19, 2023 •

edited

Loading

Uh oh!

Uh oh!

richardshiue left a comment

Uh oh!

aryan-more commented Sep 21, 2023

Uh oh!

richardshiue commented Sep 21, 2023

Uh oh!

aryan-more commented Sep 21, 2023

Uh oh!

richardshiue left a comment

Uh oh!

richardshiue commented Sep 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

aryan-more commented Sep 19, 2023

Uh oh!

CLAassistant commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

richardshiue left a comment

Choose a reason for hiding this comment

Uh oh!

aryan-more commented Sep 21, 2023

Uh oh!

richardshiue commented Sep 21, 2023

Uh oh!

aryan-more commented Sep 21, 2023

Uh oh!

richardshiue left a comment

Choose a reason for hiding this comment

Uh oh!

richardshiue commented Sep 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Sep 19, 2023 •

edited

Loading

codecov bot commented Sep 19, 2023 •

edited

Loading