Skip to content

fix: card detail regression on desktop#3977

Merged
richardshiue merged 1 commit intoAppFlowy-IO:mainfrom
richardshiue:fix-integration-test
Nov 21, 2023
Merged

fix: card detail regression on desktop#3977
richardshiue merged 1 commit intoAppFlowy-IO:mainfrom
richardshiue:fix-integration-test

Conversation

@richardshiue
Copy link
Collaborator

@richardshiue richardshiue commented Nov 21, 2023

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@richardshiue richardshiue added the regression This worked/were included in a previous verison, but stopped working in a new version label Nov 21, 2023
@richardshiue richardshiue changed the title test: fix integration tests fix: card detail regression on desktop Nov 21, 2023
@codecov
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (acc951c) 10.29% compared to head (6f1d99f) 55.97%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3977       +/-   ##
===========================================
+ Coverage   10.29%   55.97%   +45.68%     
===========================================
  Files         656      654        -2     
  Lines       30158    30042      -116     
===========================================
+ Hits         3104    16816    +13712     
+ Misses      27054    13226    -13828     
Flag Coverage Δ
appflowy_flutter_integrateion_test 55.97% <100.00%> (?)
appflowy_flutter_unit_test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardshiue richardshiue merged commit b00d29d into AppFlowy-IO:main Nov 21, 2023
@richardshiue richardshiue deleted the fix-integration-test branch November 21, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

regression This worked/were included in a previous verison, but stopped working in a new version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant