Skip to content

fix: mobile url cell focusnode fix#4029

Merged
LucasXu0 merged 1 commit intoAppFlowy-IO:mainfrom
Xazin:fix/mobile-grid-minor-fixes
Nov 28, 2023
Merged

fix: mobile url cell focusnode fix#4029
LucasXu0 merged 1 commit intoAppFlowy-IO:mainfrom
Xazin:fix/mobile-grid-minor-fixes

Conversation

@Xazin
Copy link
Contributor

@Xazin Xazin commented Nov 28, 2023

  • When you press on a URL cell, no matter where in the internal padding of the cell, the textfield will be focused

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@codecov
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c659cf4) 54.55% compared to head (6730c55) 54.58%.
Report is 3 commits behind head on main.

Files Patch % Lines
...ation/database/card/row/cells/mobile_url_cell.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4029      +/-   ##
==========================================
+ Coverage   54.55%   54.58%   +0.02%     
==========================================
  Files         685      684       -1     
  Lines       31763    31754       -9     
==========================================
+ Hits        17329    17333       +4     
+ Misses      14434    14421      -13     
Flag Coverage Δ
appflowy_flutter_integrateion_test 52.98% <0.00%> (+0.02%) ⬆️
appflowy_flutter_unit_test 9.69% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xazin Xazin requested a review from LucasXu0 November 28, 2023 02:31
@LucasXu0 LucasXu0 merged commit 1e6762b into AppFlowy-IO:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants