Skip to content

fix: simple table bugs#6981

Merged
qinluhe merged 1 commit intomainfrom
fix/simple-table-bugs
Dec 13, 2024
Merged

fix: simple table bugs#6981
qinluhe merged 1 commit intomainfrom
fix/simple-table-bugs

Conversation

@qinluhe
Copy link
Contributor

@qinluhe qinluhe commented Dec 12, 2024

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 76.02740% with 35 lines in your changes missing coverage. Please review.

Project coverage is 64.42%. Comparing base (3522569) to head (122a994).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...omponents/blocks/simple-table/SimpleTable.hooks.ts 0.00% 26 Missing ⚠️
...tor/components/blocks/simple-table/SimpleTable.tsx 0.00% 6 Missing ⚠️
...components/blocks/simple-table/SimpleTableCell.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6981      +/-   ##
==========================================
- Coverage   64.61%   64.42%   -0.19%     
==========================================
  Files         278      280       +2     
  Lines       10707    10738      +31     
  Branches     1442     1449       +7     
==========================================
  Hits         6918     6918              
- Misses       3615     3648      +33     
+ Partials      174      172       -2     
Flag Coverage Δ
appflowy_web_app 64.42% <76.02%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qinluhe qinluhe merged commit ebb1b6d into main Dec 13, 2024
@qinluhe qinluhe deleted the fix/simple-table-bugs branch December 13, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant