fix: uri paste from Safari becoming blank pastes#7280
Closed
chrisirhc wants to merge 1 commit intoAppFlowy-IO:mainfrom
Closed
fix: uri paste from Safari becoming blank pastes#7280chrisirhc wants to merge 1 commit intoAppFlowy-IO:mainfrom
chrisirhc wants to merge 1 commit intoAppFlowy-IO:mainfrom
Conversation
Safari's (or GitHub) Share button -> Copy copies a rich text link that results in noop in the Appflowy when pasting. Workaround: tap in the address bar to copy and paste
This was referenced Jan 24, 2025
Collaborator
|
Fixed in this PR. #7326 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR demonstrating issue and fix for part of #7214 :
This is a pretty hacky fix, but it demonstrates the issue where the uri type needs to be manually converted to html to be used by the paste. Otherwise, the paste results in a noop per the recording in #7214 .
Feature Preview
PR Checklist
Fixes #7283