Skip to content

fix: uri paste from Safari becoming blank pastes#7280

Closed
chrisirhc wants to merge 1 commit intoAppFlowy-IO:mainfrom
chrisirhc:chua/7214-uri-paste
Closed

fix: uri paste from Safari becoming blank pastes#7280
chrisirhc wants to merge 1 commit intoAppFlowy-IO:mainfrom
chrisirhc:chua/7214-uri-paste

Conversation

@chrisirhc
Copy link

@chrisirhc chrisirhc commented Jan 24, 2025

Draft PR demonstrating issue and fix for part of #7214 :

Safari's (or GitHub) Share button -> Copy copies a rich text link that results in noop in the Appflowy when pasting. Workaround: tap in the address bar to copy and paste

This is a pretty hacky fix, but it demonstrates the issue where the uri type needs to be manually converted to html to be used by the paste. Otherwise, the paste results in a noop per the recording in #7214 .

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Fixes #7283

Safari's (or GitHub) Share button -> Copy copies a rich text link that results in noop in the Appflowy when pasting. Workaround: tap in the address bar to copy and paste
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2025

CLA assistant check
All committers have signed the CLA.

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Feb 7, 2025

Fixed in this PR. #7326

@LucasXu0 LucasXu0 closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] iOS copied links paste into a blank string

3 participants