Skip to content

Feat embed code#985

Merged
LucasXu0 merged 25 commits intoAppFlowy-IO:mainfrom
rileyhawk1417:feat_embed_code
Sep 12, 2022
Merged

Feat embed code#985
LucasXu0 merged 25 commits intoAppFlowy-IO:mainfrom
rileyhawk1417:feat_embed_code

Conversation

@rileyhawk1417
Copy link
Collaborator

Added Bold and Italic styles to "Embed Code" feature.

rileyhawk1417 and others added 24 commits July 8, 2022 16:54
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #985 (f6a7511) into main (1188919) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
- Coverage   72.25%   72.21%   -0.05%     
==========================================
  Files          68       68              
  Lines        3882     3894      +12     
==========================================
+ Hits         2805     2812       +7     
- Misses       1077     1082       +5     
Impacted Files Coverage Δ
...efault_text_operations/format_rich_text_style.dart 69.47% <0.00%> (-1.50%) ⬇️
...wy_editor/lib/src/render/toolbar/toolbar_item.dart 84.24% <66.66%> (-0.76%) ⬇️
...itor/lib/src/render/rich_text/rich_text_style.dart 91.00% <71.42%> (-0.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rileyhawk1417 rileyhawk1417 marked this pull request as ready for review September 6, 2022 08:49
@rileyhawk1417
Copy link
Collaborator Author

This new PR is meant to close issue #911

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Sep 6, 2022

@rileyhawk1417 LGTM. Please remember to add the related tests for this new feature.

@LucasXu0 LucasXu0 merged commit f4cf5d0 into AppFlowy-IO:main Sep 12, 2022
@LucasXu0
Copy link
Collaborator

#911

@LucasXu0 LucasXu0 mentioned this pull request Sep 13, 2022
7 tasks
zoli pushed a commit to LucasXu0/AppFlowy that referenced this pull request Aug 30, 2023
* fix: fix linux build

* Merge pull request AppFlowy-IO#599 from AppFlowy-IO/refactor/grid_decode_cell_data

Refactor/grid decode cell data

* refactor: cleaned up and added bold, italic styles

* refactor: remove bold & italic styles

Co-authored-by: Nathan.fooo <86001920+appflowy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants