fix(browser): hide spinner on main-frame load errors in BrowserClient#68
Merged
LandWarderer2772 merged 1 commit intoMay 17, 2026
Merged
Conversation
BrowserClient flips BrowserCallback.onLoadingStateChanged on onPageStarted (true) and onPageFinished (false), but does not override onReceivedError. On many failure modes (DNS, certificate, offline, 4xx/5xx) onPageFinished does not always fire after the error, so the toolbar / progress UI stays stuck on isLoading = true even though the page never loaded. Add a main-frame-only onReceivedError override that flips isLoading = false too. isForMainFrame keeps a single blocked sub-resource from flipping the spinner off while the main load is still running.
Member
|
Thanks, ill test it out and then merge. :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67.
BrowserClientflipsBrowserCallback.onLoadingStateChangedononPageStarted(true) andonPageFinished(false), but does not overrideonReceivedError. On many failure modes (DNS, certificate, offline, 4xx/5xx)onPageFinisheddoes not always fire after the error, so the toolbar / progress UI stays stuck onisLoading = trueeven though the page never loaded.Add a main-frame-only
onReceivedErroroverride that flipsisLoading = falsetoo:isForMainFramekeeps a single blocked sub-resource from flipping the spinner off while the main load is still running.