Skip to content

Extend spec to give any app icons in usr/share/icons preference #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
probonopd merged 2 commits into from
Jan 1, 2019
Merged

Extend spec to give any app icons in usr/share/icons preference #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4690c61
Extend spec to give any app icons in usr/share/icons preference
kossebau Dec 28, 2018
d1927ad
Fix typo ot -> or
kossebau Dec 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion draft.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ An [AppImage] which conforms to the type 2 image format:
* **MUST** contain a file named `AppRun` in its root directory
* **SHOULD** contain a [payload application] that is ultimately executed when the [AppImage] is executed
* **SHOULD** contain exactly one `$APPNAME.desktop` file in its root directory with `$APPNAME` being the name of the [payload application]
* **MAY** contain an `$APPNAME.png` file in its root directory with `$APPNAME` being the name of the [payload application] as set in the `Icon=` key of the `$APPNAME.desktop` file. If present, this icon **SHOULD** be given preference as the icon being used to represent the [AppImage]. The icon **SHOULD** be a PNG with 256x256 or 512x512 pixels
* **MAY** contain icon files below `usr/share/icons/hicolor` following the [Icon Theme Specification](https://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html) for the icon identifier as set in the `Icon=` key of the `$APPNAME.desktop` file. If present, these icon files **SHOULD** be given preference as the icon being used to represent the [AppImage].
* **MAY** contain an `$APPICON.svg`, `$APPICON.svgz` or `$APPICON.png` file in its root directory with `$APPICON` being the icon identifier as set in the `Icon=` key of the `$APPNAME.desktop` file. If present and no icon files matching the icon identifier present below `usr/share/icons/hicolor`, this icon **SHOULD** be given preference as the icon being used to represent the [AppImage]. If a PNG file, the icon **SHOULD** be of size 256x256, 512x512, or 1024x1024 pixels.
Copy link
Copy Markdown
Member

@TheAssassin TheAssassin Jan 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should highlight that PNG files are the ones which do work, the SVG stuff isn't supported by libappimage (might be changed by @azubieta at some point).

Copy link
Copy Markdown
Member

@probonopd probonopd Jan 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec should not be written based on what some concrete implementations happen to do at the moment; it should describe the target picture. I think it is quite clear that throughout the Linux desktop, png, svg, svgz, and xpm (legacy) have to be supported.

* **SHOULD** contain a `.DirIcon` file as per the [AppDir] specification

#### The `AppRun` file:
Expand Down