Skip to content

Add data-tracking attributes to language switcher and login buttons #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sinatragianpaolo merged 3 commits into from
Jan 24, 2024
Merged

Add data-tracking attributes to language switcher and login buttons #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
650e00b
Add data-tracking attributes to language switcher and login buttons
Jan 23, 2024
cce0ac6
chore: Update appquality-design-system to version 1.0.68
Jan 23, 2024
6a60503
Add data-tracking attributes to links in Step1 component
Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.2.0",
"private": true,
"dependencies": {
"@appquality/appquality-design-system": "^1.0.67",
"@appquality/appquality-design-system": "^1.0.68",
"@appquality/craft-blocks": "^0.1.27",
"@datadog/browser-logs": "^3.4.1",
"@reduxjs/toolkit": "^1.8.2",
Expand Down
3 changes: 3 additions & 0 deletions src/features/LangMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export const LangMenu = ({
<li>
<a
data-qa="language-switcher-it"
data-tracking="lang-switcher-it"
href={itLink}
className={`${
i18n.language === "it" ? "current " : ""
Expand All @@ -69,6 +70,7 @@ export const LangMenu = ({
<li>
<a
data-qa="language-switcher-en"
data-tracking="lang-switcher-en"
href={enLink}
className={`${
i18n.language === "en" ? "current " : ""
Expand All @@ -83,6 +85,7 @@ export const LangMenu = ({
<li>
<a
data-qa="language-switcher-es"
data-tracking="lang-switcher-es"
href={esLink}
className={`${
i18n.language === "es" ? "current " : ""
Expand Down
5 changes: 5 additions & 0 deletions src/features/LoginForm/LoginFields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ const LoginFields = ({ cta, error }: LoginFieldsProps) => {
size="block"
flat
data-qa="login-facebook-button"
data-tracking="facebook-login-cta"
onClick={() => {
window.location.href = `/wp-admin/admin-ajax.php?loc=${
redirectTo ? redirectTo : pathname
Expand All @@ -66,6 +67,7 @@ const LoginFields = ({ cta, error }: LoginFieldsProps) => {
size="block"
flat
data-qa="login-linkedin-button"
data-tracking="linkedin-login-cta"
onClick={() => {
window.location.href = `/wp-admin/admin-ajax.php?loc=${
redirectTo ? redirectTo : pathname
Expand Down Expand Up @@ -144,6 +146,7 @@ const LoginFields = ({ cta, error }: LoginFieldsProps) => {
<a
className="aq-text-secondary lost-password-anchor"
href="/wp-login.php?action=lostpassword"
data-tracking="forgot-password-link"
>
{t("forgot your password?")}
</a>
Expand All @@ -154,6 +157,7 @@ const LoginFields = ({ cta, error }: LoginFieldsProps) => {
size="block"
type="submit"
formNoValidate
data-tracking="email-pass-login-cta"
>
{isSubmitting ? t("wait...") : cta}
</Button>
Expand All @@ -165,6 +169,7 @@ const LoginFields = ({ cta, error }: LoginFieldsProps) => {
strong: <strong className="aq-text-secondary" />,
signuplink: (
<Link
data-tracking="signup-link"
style={{
display: "inline-block",
textDecoration: "none",
Expand Down
7 changes: 6 additions & 1 deletion src/pages/GettingStarted/NewSignupForm/Step0/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,12 @@ const Step0 = () => {
<EmailInput className="aq-mb-3" />
<PasswordInput className="aq-mb-2" />
<PasswordRequirements />
<Button size="block" kind="primary" onClick={goToNextStep}>
<Button
size="block"
kind="primary"
onClick={goToNextStep}
data-tracking="signup-next-cta"
>
{t("SIGNUP_STEP:::continue")}
</Button>
</div>
Expand Down
16 changes: 14 additions & 2 deletions src/pages/GettingStarted/NewSignupForm/Step1/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,10 @@ const Step1 = () => {
meta,
}: FieldProps) => {
return (
<div className="aq-mb-3">
<div
className="aq-mb-3"
data-tracking="signup-agree-to-receive-email"
>
<Checkbox
name={name}
id={name}
Expand Down Expand Up @@ -157,6 +160,7 @@ const Step1 = () => {
ns: "links",
})}
target="_blank"
data-tracking="terms-condictions-link"
/>
),
privacy_link: (
Expand All @@ -166,6 +170,7 @@ const Step1 = () => {
ns: "links",
})}
target="_blank"
data-tracking="privacy-policy-link"
/>
),
ethical_link: (
Expand All @@ -175,21 +180,28 @@ const Step1 = () => {
ns: "links",
})}
target="_blank"
data-tracking="ethical-code-link"
/>
),
}}
defaults="By signing up, you also accept the the <terms_link>Terms</terms_link>, <privacy_link>Privacy Policy</privacy_link> and <ethical_link>Ethical Code</ethical_link> of tryber.me"
/>
</Text>
<ButtonWrapper>
<Button size="block" flat onClick={onBackClick}>
<Button
size="block"
flat
onClick={onBackClick}
data-tracking="signup-back-cta"
>
{t("SIGNUP_STEP:::back")}
</Button>
<Button
size="block"
type="submit"
disabled={isSubmitting}
onClick={onSubmitClick}
data-tracking="signup-submit-cta"
>
{t("SIGNUP_STEP:::submit")}
</Button>
Expand Down
7 changes: 7 additions & 0 deletions src/pages/GettingStarted/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export default function GettingStarted() {
className="aq-mb-3"
size="block"
flat
data-tracking="facebook-signup-cta"
>
<img
aria-hidden
Expand All @@ -71,6 +72,7 @@ export default function GettingStarted() {
className="aq-mb-3"
size="block"
flat
data-tracking="linkedin-signup-cta"
>
<img
aria-hidden
Expand All @@ -86,6 +88,7 @@ export default function GettingStarted() {
size="block"
data-qa="email-signup"
onClick={onEmailSignupClick}
data-tracking="email-signup-cta"
>
<EnvelopeFill
aria-hidden
Expand All @@ -107,6 +110,7 @@ export default function GettingStarted() {
ns: "links",
})}
target="_blank"
data-tracking="terms-condictions-link"
/>
),
privacy_link: (
Expand All @@ -119,6 +123,7 @@ export default function GettingStarted() {
}
)}
target="_blank"
data-tracking="privacy-policy-link"
/>
),
ethical_link: (
Expand All @@ -128,6 +133,7 @@ export default function GettingStarted() {
ns: "links",
})}
target="_blank"
data-tracking="ethical-code-link"
/>
),
}}
Expand All @@ -143,6 +149,7 @@ export default function GettingStarted() {
to={login}
data-qa="login"
style={{ textDecoration: "none" }}
data-tracking="login-link"
/>
),
strong: <strong />,
Expand Down
1 change: 1 addition & 0 deletions src/pages/SignupSuccess/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export default function SignupSuccess() {
kind="primary"
size="block"
onClick={goToDashboard}
data-tracking="go-to-dashboard-cta"
>
{t("Go to dashboard")}
</Button>
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@
ajv-draft-04 "^1.0.0"
call-me-maybe "^1.0.1"

"@appquality/appquality-design-system@^1.0.67":
version "1.0.67"
resolved "https://registry.yarnpkg.com/@appquality/appquality-design-system/-/appquality-design-system-1.0.67.tgz#e822454a7c7345f3a699087c80b1ae9567bf7c89"
integrity sha512-uIEJrX+PgVc4yF/4ciFYuqnP9v78PtYRpSfHx42/iEmI9qx2bFXuxuAgU8003+DBdmb33A7LLe0k0axoLUNLuA==
"@appquality/appquality-design-system@^1.0.68":
version "1.0.68"
resolved "https://registry.yarnpkg.com/@appquality/appquality-design-system/-/appquality-design-system-1.0.68.tgz#ae9c8d385fa8ed4a239a9f513c55922c6e6d0733"
integrity sha512-UYoGphqfGuhEZMocLpEjkJBlUYBST4omjx1YOgVHuyYM3nbqY+pOHQZwsBnRP6+voPY/AjYbTUAjBXMz00tR5w==
dependencies:
"@appquality/mobiscroll" "^5.10.1"
formik "^2.2.9"
Expand Down